From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-block@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-nvme@lists.infradead.org, Stefan Roesch <shr@fb.com>
Subject: Re: [PATCH 4/5] nvme: split out metadata vs non metadata end_io uring_cmd completions
Date: Mon, 26 Sep 2022 08:41:38 -0600 [thread overview]
Message-ID: <69598e37-fb91-5b92-bb80-b68457a7b6f8@kernel.dk> (raw)
In-Reply-To: <YzG5/1zSdiMlMLnB@infradead.org>
On 9/26/22 8:41 AM, Christoph Hellwig wrote:
> On Fri, Sep 23, 2022 at 02:52:54PM -0600, Jens Axboe wrote:
>> For both of these, how about we just simplify like below? I think
>> at that point it's useless to name them anyway.
>
> I think this version is better than the previous one, but I'd still
> prefer a non-anonymous union.
Sure, I don't really care. What name do you want for it?
--
Jens Axboe
next prev parent reply other threads:[~2022-09-26 14:41 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-22 18:28 [PATCHSET 0/5] Enable alloc caching and batched freeing for passthrough Jens Axboe
2022-09-22 18:28 ` [PATCH 1/5] block: enable batched allocation for blk_mq_alloc_request() Jens Axboe
2022-09-23 14:52 ` Pankaj Raghav
2022-09-23 15:13 ` Pankaj Raghav
2022-09-23 20:54 ` Jens Axboe
2022-09-24 0:59 ` Damien Le Moal
2022-09-24 1:01 ` Jens Axboe
2022-09-24 1:22 ` Damien Le Moal
2022-09-24 11:56 ` Pankaj Raghav
2022-09-24 14:44 ` Jens Axboe
2022-09-22 18:28 ` [PATCH 2/5] block: change request end_io handler to pass back a return value Jens Axboe
2022-09-22 18:28 ` [PATCH 3/5] block: allow end_io based requests in the completion batch handling Jens Axboe
2022-09-22 18:28 ` [PATCH 4/5] nvme: split out metadata vs non metadata end_io uring_cmd completions Jens Axboe
2022-09-23 15:21 ` Christoph Hellwig
2022-09-23 20:52 ` Jens Axboe
2022-09-26 14:41 ` Christoph Hellwig
2022-09-26 14:41 ` Jens Axboe [this message]
2022-09-26 14:43 ` Christoph Hellwig
2022-09-26 14:50 ` Jens Axboe
2022-09-26 14:52 ` Christoph Hellwig
2022-09-26 14:54 ` Jens Axboe
2022-09-22 18:28 ` [PATCH 5/5] nvme: enable batched completions of passthrough IO Jens Axboe
2022-09-23 15:16 ` [PATCHSET 0/5] Enable alloc caching and batched freeing for passthrough Christoph Hellwig
2022-09-23 15:19 ` Jens Axboe
2022-09-23 15:21 ` Christoph Hellwig
2022-09-23 15:22 ` Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2022-09-27 1:44 [PATCHSET v2 " Jens Axboe
2022-09-27 1:44 ` [PATCH 4/5] nvme: split out metadata vs non metadata end_io uring_cmd completions Jens Axboe
2022-09-27 7:50 ` Christoph Hellwig
2022-09-28 13:51 ` Anuj gupta
2022-09-28 14:47 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69598e37-fb91-5b92-bb80-b68457a7b6f8@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=shr@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox