From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C0729C433F5 for ; Fri, 6 May 2022 13:38:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=sbVEiPB7DLhgzb0h3YbXUVmLT41Mdwi+DyNQZNorIr0=; b=19KNdsc27f9d7p7QK/1P16ip/s RUpxO803Rz7+pvwALzYaVTukUlygc0AyG7R4Zk68OTRRGZs6SfOAmG23kd6aLLObk+jv8N66+YGY1 XFm+4jVlhWmc3yXcPUPcs8k1il2VAQswYvNZgnKxXF6krxjXYSdu/8kkMLzC+Ax4DsCjb8yT9MCaw 9q1E3kuHbWmKayhUxEVRhmo0N/PcbkL4TbfH0zjLSO+jVNZt24j4TX5Fu+tlHeDTpOMgLHAItWoYZ obs+j+gvYvkgUzjaf5m40cmIFNNiUnY0+PmqS7jYw34/wqy/fEk0yshkBadQg1isxRgTLigecE3An 2BaMwF/Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmy9l-003XJn-0f; Fri, 06 May 2022 13:38:05 +0000 Received: from mail-pf1-x42e.google.com ([2607:f8b0:4864:20::42e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmy9h-003XGz-Oz for linux-nvme@lists.infradead.org; Fri, 06 May 2022 13:38:03 +0000 Received: by mail-pf1-x42e.google.com with SMTP id c14so6288561pfn.2 for ; Fri, 06 May 2022 06:37:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=sbVEiPB7DLhgzb0h3YbXUVmLT41Mdwi+DyNQZNorIr0=; b=a6v5h7KLCIozI6Y+WgpdPZI7xbgZNQqwwKQa9KWRlE5yxvJuSmRXOUdE8f3goZPA52 Sc25UpxK+AFd2ak6vNBAErYRGl08x6ToqYa/dHthkNs6JbObwn6yXPzRn/TLjOwe4b2q 1WHQUWR5RTmwBWoQmGVJM09EZn+n4r5esqoMqjV1tu8VpAd+wTgT3NdEamvGad+/O8dA Z0xxIwWm9aSySzQeTEz+nhLwSyBjHnOtv6OHO33AMlkQgm8ugO2Kp6nAbzvYsH33Dbyi qovTohA+gQUp9Tfrj2NYe9k/2+B1VIy8BkJ5CKMY4qntWVpqhdhuCaOrmWD74SFv2qee Ki9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=sbVEiPB7DLhgzb0h3YbXUVmLT41Mdwi+DyNQZNorIr0=; b=NtXLMKVt7V/3/O4OOWPMe0gbqcjAj69yAljQY98J63J1RCQgmXPHOr+EaUqmQ7PXx0 /G/vjPCQZWj4XMT5GyRX3qGWKjWeQSPCj90s3mZRbNzbS0+S6TYSUsz2LArwmIh3Bc5L GO3PRIXUfmHOwX1MCfGxbu1q0+LojLjbhU0PM+/3dHccdivFhp+lE13EBsMB4WmNiRYA jAP/0XZGHx1daIE4Wt3WzNI9iDsDEdBRuzD1hYLLWOHcGKPE5axTSKvZYZpDgQ3LXp/J VClgI+8suBL1wz5LJzn19aqYWWJURfX3xYzeVIiC8cwMNS5evSYm6hj4lh8P8B0vwB7w 547A== X-Gm-Message-State: AOAM532lzi+IdIamYdgeN7zEq14RqNG9Rxm/8TO1IOLr8wNJKL8puuWd Z/+PK9XCxkOE6aHsfl9r2uvt8Q== X-Google-Smtp-Source: ABdhPJx+NPzTXXuqi+jjhDCyeH7IAjECslxDiL5xxuY6CRwPScOD3AiaoJeWKbJItj4+ugjvbYFBWw== X-Received: by 2002:a63:5d10:0:b0:3c5:e836:ffd2 with SMTP id r16-20020a635d10000000b003c5e836ffd2mr2856602pgb.32.1651844277797; Fri, 06 May 2022 06:37:57 -0700 (PDT) Received: from [192.168.4.166] (cpe-72-132-29-68.dc.res.rr.com. [72.132.29.68]) by smtp.gmail.com with ESMTPSA id q1-20020a170902dac100b0015e8d4eb2dfsm1727376plx.297.2022.05.06.06.37.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 May 2022 06:37:57 -0700 (PDT) Message-ID: <6b0811df-e2a4-22fc-7615-44e5615ce6a4@kernel.dk> Date: Fri, 6 May 2022 07:37:55 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v4 4/5] nvme: wire-up uring-cmd support for io-passthru on char-device. Content-Language: en-US To: Christoph Hellwig Cc: Kanchan Joshi , io-uring@vger.kernel.org, linux-nvme@lists.infradead.org, asml.silence@gmail.com, ming.lei@redhat.com, mcgrof@kernel.org, shr@fb.com, joshiiitr@gmail.com, anuj20.g@samsung.com, gost.dev@samsung.com References: <20220505060616.803816-1-joshi.k@samsung.com> <20220505060616.803816-5-joshi.k@samsung.com> <20220505134256.GA13109@lst.de> <8ae2c507-ffcc-b693-336d-2d9f907edb76@kernel.dk> <20220506082844.GA30405@lst.de> From: Jens Axboe In-Reply-To: <20220506082844.GA30405@lst.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220506_063801_841676_96ECB8FF X-CRM114-Status: GOOD ( 17.11 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On 5/6/22 2:28 AM, Christoph Hellwig wrote: > On Thu, May 05, 2022 at 11:23:01AM -0600, Jens Axboe wrote: >> The top three patches here have a proposed solution for the 3 issues >> that I highlighted: >> >> https://git.kernel.dk/cgit/linux-block/log/?h=for-5.19/io_uring-passthrough >> >> Totally untested... Kanchan, can you take a look and see what you think? >> They all need folding obviously, I just tried to do them separately. >> Should also get tested :-) > > I've also pushed out a tree based on this, which contains my little > fixups that I'd suggest to be folded. Totally untested and written > while jetlagged: > > http://git.infradead.org/users/hch/block.git/shortlog/refs/heads/io_uring-passthrough > > Note that while I tried to keep all my changes in separate patches, the > main passthrough patch had conflicts during a rebase, which I had to > fix up, but I tried to touch as little as possible. Folded most of it, but I left your two meta data related patches as separate as I they really should be separate. However, they need a proper commit message and signed-off-by from you. It's these two: https://git.kernel.dk/cgit/linux-block/commit/?h=for-5.19/io_uring-passthrough&id=b855a4458068722235bdf69688448820c8ddae8e https://git.kernel.dk/cgit/linux-block/commit/?h=for-5.19/io_uring-passthrough&id=2be698bdd668daeb1aad2ecd516484a62e948547 Can you do those as proper patches? I did not do your async_size changes, I think you're jetlagged eyes missed that this isn't a sizeof thing on a flexible array, it's just the offset of it. Hence for non-sqe128, the the async size is io_uring_sqe - offsetof where pdu starts, and so forth. -- Jens Axboe