From: Sagi Grimberg <sagi@grimberg.me>
To: Hannes Reinecke <hare@suse.de>, Christoph Hellwig <hch@lst.de>
Cc: linux-nvme@lists.infradead.org, Daniel Wagner <dwagner@suse.de>,
Keith Busch <keith.busch@wdc.com>,
James Smart <james.smart@broadcom.com>
Subject: Re: [PATCH 1/5] nvme: add NVME_REQ_CANCELLED flag in nvme_cancel_request()
Date: Thu, 28 Jan 2021 00:15:48 -0800 [thread overview]
Message-ID: <6be12f35-7674-83ff-b6ef-ee51170e8d79@grimberg.me> (raw)
In-Reply-To: <20210127103326.16191-2-hare@suse.de>
> NVME_REQ_CANCELLED is translated into -EINTR in nvme_submit_sync_cmd(),
> so we should be setting this flags during nvme_cancel_request() to
> ensure that the callers to nvme_submit_sync_cmd() will get the correct
> error code when the controller is reset.
We will have an issue here. Because now nvme_validate_ns will return
EINTR, which means that now scans failing to validate during resets
will now end up incorrectly removing the namespace:
--
out:
/*
* Only remove the namespace if we got a fatal error back from the
* device, otherwise ignore the error and just move on.
*
* TODO: we should probably schedule a delayed retry here.
*/
if (ret && ret != -ENOMEM && !(ret > 0 && !(ret & NVME_SC_DNR)))
nvme_ns_remove(ns);
--
Did you check resets loop with scans with this?
If we go down this path (we already had this discussion in the
past), we need to decide on either of:
- Don't remove the namespace for any of the return codes from
nvme_submit_sync_cmd (understanding that this may be just a
transport issue).
- Or, return the raw positive nvme status (which doesn't have
the DNR bit set) and make sure we return ret codes on top.
But this change alone, re-triggers a condition that during
resets a namespace is incorrectly removed.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-01-28 8:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-27 10:33 [PATCHv2 0/5][RESEND] Fixup return value for nvme_submit_sync_cmd() Hannes Reinecke
2021-01-27 10:33 ` [PATCH 1/5] nvme: add NVME_REQ_CANCELLED flag in nvme_cancel_request() Hannes Reinecke
2021-01-27 15:05 ` Keith Busch
2021-01-28 8:15 ` Sagi Grimberg [this message]
2021-01-27 10:33 ` [PATCH 2/5] nvme-fc: set NVME_REQ_CANCELLED in nvme_fc_terminate_exchange() Hannes Reinecke
2021-01-27 10:59 ` Daniel Wagner
2021-01-27 10:33 ` [PATCH 3/5] nvme-fc: return NVME_SC_HOST_ABORTED_CMD when a command has been aborted Hannes Reinecke
2021-01-27 11:00 ` Daniel Wagner
2021-01-27 10:33 ` [PATCH 4/5] nvme: return NVME_SC_ABORT_QUEUE for cancelled commands Hannes Reinecke
2021-01-27 11:01 ` Daniel Wagner
2021-01-27 10:33 ` [PATCH 5/5] nvme: return -ETIMEDOUT in nvme_submit_sync_cmd() Hannes Reinecke
2021-01-27 11:00 ` Daniel Wagner
2021-01-27 15:09 ` [PATCHv2 0/5][RESEND] Fixup return value for nvme_submit_sync_cmd() Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6be12f35-7674-83ff-b6ef-ee51170e8d79@grimberg.me \
--to=sagi@grimberg.me \
--cc=dwagner@suse.de \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=james.smart@broadcom.com \
--cc=keith.busch@wdc.com \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox