From: Jens Axboe <axboe@kernel.dk>
To: Hannes Reinecke <hare@suse.de>, Christoph Hellwig <hch@lst.de>
Cc: Sagi Grimberg <sagi@grimberg.me>, Keith Busch <kbusch@kernel.org>,
Yi Zhang <yi.zhang@redhat.com>,
linux-nvme@lists.infradead.org,
Maurizio Lombardi <mlombard@redhat.com>
Subject: Re: [PATCHv2] nvmet-tcp: do not try to cancel uninitialized tls_handshake_tmo_work
Date: Thu, 19 Oct 2023 08:17:28 -0600 [thread overview]
Message-ID: <6beec109-8611-4dde-adaa-3d7bb0e3ca21@kernel.dk> (raw)
In-Reply-To: <20231019133417.23440-1-hare@suse.de>
On 10/19/23 7:34 AM, Hannes Reinecke wrote:
> The TLS handshake timeout workqueue is only initialized if TLS
> is configured, so we shouldn't try to de-initialize it
> unconditionally.
Please fix this properly rather than working around it. Either put the
work item inside CONFIG_NVME_TARGET_TCP_TLS so that any unintended use
can't happen in the future, or just initialize the darn thing at setup
time rather than have this conditional.
--
Jens Axboe
prev parent reply other threads:[~2023-10-19 14:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-19 13:34 [PATCHv2] nvmet-tcp: do not try to cancel uninitialized tls_handshake_tmo_work Hannes Reinecke
2023-10-19 14:17 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6beec109-8611-4dde-adaa-3d7bb0e3ca21@kernel.dk \
--to=axboe@kernel.dk \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mlombard@redhat.com \
--cc=sagi@grimberg.me \
--cc=yi.zhang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox