From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Guixin Liu <kanie@linux.alibaba.com>,
"shinichiro.kawasaki@wdc.com" <shinichiro.kawasaki@wdc.com>,
"dwagner@suse.de" <dwagner@suse.de>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH blktests v3 2/2] nvme: test the nvme reservation feature
Date: Mon, 14 Oct 2024 06:43:15 +0000 [thread overview]
Message-ID: <6e1e4df5-ccee-4a92-80ac-64976a526003@nvidia.com> (raw)
In-Reply-To: <20241012111157.44368-3-kanie@linux.alibaba.com>
On 10/12/24 04:11, Guixin Liu wrote:
> Test the NVMe reservation feature, including register, acquire,
> release and report.
>
> Signed-off-by: Guixin Liu <kanie@linux.alibaba.com>
> ---
> tests/nvme/054 | 99 +++++++++++++++++++++++++++++++++++++++++
> tests/nvme/054.out | 108 +++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 207 insertions(+)
> create mode 100644 tests/nvme/054
> create mode 100644 tests/nvme/054.out
>
> diff --git a/tests/nvme/054 b/tests/nvme/054
> new file mode 100644
> index 0000000..f352c73
> --- /dev/null
> +++ b/tests/nvme/054
> @@ -0,0 +1,99 @@
> +#!/bin/bash
> +# SPDX-License-Identifier: GPL-3.0+
> +# Copyright (C) 2024 Guixin Liu
> +# Copyright (C) 2024 Alibaba Group.
> +#
> +# Test the NVMe reservation feature
> +#
> +. tests/nvme/rc
> +
> +DESCRIPTION="Test the NVMe reservation feature"
> +QUICK=1
> +nvme_trtype="loop"
> +
> +requires() {
> + _nvme_requires
> +}
> +
> +resv_report() {
> + local nvmedev=$1
> + local report_arg=$2
> +
> + nvme resv-report "/dev/${nvmedev}n1" "${report_arg}" | grep -v "hostid"
> +}
> +
> +test_resv() {
> + local nvmedev=$1
> + local report_arg="--cdw11=1"
> +
> + if nvme resv-report --help 2>&1 | grep -- '--eds' > /dev/null; then
> + report_arg="--eds"
> + fi
> +
> + echo "Register"
> + resv_report "${nvmedev}" "${report_arg}"
> + nvme resv-register "/dev/${nvmedev}n1" --nrkey=4 --rrega=0
> + resv_report "${nvmedev}" "${report_arg}"
> +
> + echo "Replace"
> + nvme resv-register "/dev/${nvmedev}n1" --crkey=4 --nrkey=5 --rrega=2
> + resv_report "${nvmedev}" "${report_arg}"
> +
> + echo "Unregister"
> + nvme resv-register "/dev/${nvmedev}n1" --crkey=5 --rrega=1
> + resv_report "${nvmedev}" "${report_arg}"
> +
> + echo "Acquire"
> + nvme resv-register "/dev/${nvmedev}n1" --nrkey=4 --rrega=0
> + nvme resv-acquire "/dev/${nvmedev}n1" --crkey=4 --rtype=1 --racqa=0
> + resv_report "${nvmedev}" "${report_arg}"
> +
> + echo "Preempt"
> + nvme resv-acquire "/dev/${nvmedev}n1" --crkey=4 --rtype=2 --racqa=1
> + resv_report "${nvmedev}" "${report_arg}"
> +
> + echo "Release"
> + nvme resv-release "/dev/${nvmedev}n1" --crkey=4 --rtype=2 --rrela=0
> + resv_report "${nvmedev}" "${report_arg}"
> +
> + echo "Clear"
> + nvme resv-register "/dev/${nvmedev}n1" --nrkey=4 --rrega=0
> + nvme resv-acquire "/dev/${nvmedev}n1" --crkey=4 --rtype=1 --racqa=0
> + resv_report "${nvmedev}" "${report_arg}"
> + nvme resv-release "/dev/${nvmedev}n1" --crkey=4 --rrela=1
> +}
> +
> +
make it easier to debug totally untested :-
test_resv() {
local nvmedev=$1
local report_arg="--cdw11=1"
test_dev="/dev/${nvmedev}n1"
if nvme resv-report --help 2>&1 | grep -- '--eds' > /dev/null; then
report_arg="--eds"
fi
echo "Register"
resv_report "${nvmedev}" "${report_arg}"
nvme resv-register "${test_dev}" --nrkey=4 --rrega=0
resv_report "${nvmedev}" "${report_arg}"
echo "Replace"
nvme resv-register "${test_dev}" --crkey=4 --nrkey=5 --rrega=2
resv_report "${nvmedev}" "${report_arg}"
echo "Unregister"
nvme resv-register "${test_dev}" --crkey=5 --rrega=1
resv_report "${nvmedev}" "${report_arg}"
echo "Acquire"
nvme resv-register "${test_dev}" --nrkey=4 --rrega=0
nvme resv-acquire "${test_dev}" --crkey=4 --rtype=1 --racqa=0
resv_report "${nvmedev}" "${report_arg}"
echo "Preempt"
nvme resv-acquire "${test_dev}" --crkey=4 --rtype=2 --racqa=1
resv_report "${nvmedev}" "${report_arg}"
echo "Release"
nvme resv-release "${test_dev}" --crkey=4 --rtype=2 --rrela=0
resv_report "${nvmedev}" "${report_arg}"
echo "Clear"
nvme resv-register "${test_dev}" --nrkey=4 --rrega=0
nvme resv-acquire "${test_dev}" --crkey=4 --rtype=1 --racqa=0
resv_report "${nvmedev}" "${report_arg}"
nvme resv-release "${test_dev}" --crkey=4 --rrela=1
}
irrespective of that looks good :-
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
next prev parent reply other threads:[~2024-10-14 6:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-12 11:11 [PATCH blktests v3 0/2] Test the NVMe reservation feature Guixin Liu
2024-10-12 11:11 ` [PATCH blktests v3 1/2] nvme/{md/001,rc,002,016,017,030,052}: introduce --resv_enable argument Guixin Liu
2024-10-14 6:41 ` Chaitanya Kulkarni
2024-10-14 7:17 ` Daniel Wagner
2024-10-12 11:11 ` [PATCH blktests v3 2/2] nvme: test the nvme reservation feature Guixin Liu
2024-10-14 6:43 ` Chaitanya Kulkarni [this message]
2024-10-14 8:34 ` Guixin Liu
2024-10-14 7:23 ` Daniel Wagner
2024-10-14 8:43 ` Guixin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e1e4df5-ccee-4a92-80ac-64976a526003@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=dwagner@suse.de \
--cc=kanie@linux.alibaba.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox