From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"Rick Wertenbroek" <rick.wertenbroek@gmail.com>,
"Niklas Cassel" <cassel@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Sagi Grimberg" <sagi@grimberg.me>,
"Christoph Hellwig" <hch@lst.de>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Keith Busch" <kbusch@kernel.org>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Bjorn Helgaas" <bhelgaas@google.com>
Subject: Re: [PATCH v2 2/5] nvmef: export nvmef_create_ctrl()
Date: Mon, 14 Oct 2024 06:32:26 +0000 [thread overview]
Message-ID: <702e9570-cb93-4bc2-8b72-72ececd67ed9@nvidia.com> (raw)
In-Reply-To: <20241011121951.90019-3-dlemoal@kernel.org>
On 10/11/24 05:19, Damien Le Moal wrote:
nit:- please consider following subject line as nvmef_create_ctrl()
doesn't exists :-
nvme-fabrics: export nvmf_create_ctrl()
> Export nvmef_create_ctrl() to allow drivers to directly call this
> function instead of forcing the creation of a fabrics host controller
> with a write to /dev/nvmef. The export is restricted to the NVME_FABRICS
I'm not sure /dev/nvmef exists I think you meant /dev/nvme-fabrics
above ?
> namespace.
>
> Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
With above fix, looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
next prev parent reply other threads:[~2024-10-14 6:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-11 12:19 [PATCH v2 0/5] NVMe PCI endpoint function driver Damien Le Moal
2024-10-11 12:19 ` [PATCH v2 1/5] nvmet: rename and move nvmet_get_log_page_len() Damien Le Moal
2024-10-14 6:24 ` Chaitanya Kulkarni
2024-10-11 12:19 ` [PATCH v2 2/5] nvmef: export nvmef_create_ctrl() Damien Le Moal
2024-10-14 6:32 ` Chaitanya Kulkarni [this message]
2024-10-14 8:42 ` Christoph Hellwig
2024-10-14 9:10 ` Damien Le Moal
2024-10-14 11:45 ` Christoph Hellwig
2024-10-11 12:19 ` [PATCH v2 3/5] nvmef: Introduce the NVME_OPT_HIDDEN_NS option Damien Le Moal
2024-10-14 8:42 ` Christoph Hellwig
2024-10-14 9:12 ` Damien Le Moal
2024-10-11 12:19 ` [PATCH v2 4/5] PCI: endpoint: Add NVMe endpoint function driver Damien Le Moal
2024-10-14 8:44 ` Christoph Hellwig
2024-10-14 10:41 ` Damien Le Moal
2024-10-14 11:38 ` Christoph Hellwig
2024-10-11 12:19 ` [PATCH v2 5/5] PCI: endpoint: Document the " Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=702e9570-cb93-4bc2-8b72-72ececd67ed9@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=bhelgaas@google.com \
--cc=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kishon@kernel.org \
--cc=kw@linux.com \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=rick.wertenbroek@gmail.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox