From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_ADSP_ALL, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30034C47404 for ; Mon, 7 Oct 2019 22:11:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 018A020867 for ; Mon, 7 Oct 2019 22:11:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qKTPfCZb"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=amazon.com header.i=@amazon.com header.b="caagwnpK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 018A020867 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=amazon.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:To:From:Reply-To:Cc:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uNf6cAdaQN+oNfnyjbiTdST4E8+V89Sdp+fYt/EHtwE=; b=qKTPfCZb3Or11f F6SVKJsquvo3tY2Gc9Vgk3t5wPl8KkUqgzTaJWRzkDS25X0IgrrkCa7E01QdqZOW5p330eoUS1+ar 9ttRXrPsalLIsI2mEzMLluj+L0TftIrd7Piudy47P+WFxGIPDwE021Qog8Zor1c1HREZgjhz+6rPp QOiQ2P/s5EA1AJrM2NqihFuszOD93VXKDyZI+qYkhE79Bn/mYfzmGwJGPi7YpPEOZtkhqbstKs6ps xVHOBmPs9BhaRBUfiQtqF4SYqqrdT5gWrWRZmQeOE2VacSDEpWcDNT4XTi8axxmcE4dot8cZmJcwM MnPMnhEhVbhR8C56hyjA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iHbE6-00012e-98; Mon, 07 Oct 2019 22:11:34 +0000 Received: from smtp-fw-6001.amazon.com ([52.95.48.154]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iHbE3-00011r-In for linux-nvme@lists.infradead.org; Mon, 07 Oct 2019 22:11:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1570486291; x=1602022291; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=fwumaDoNR8/M5OTVKavfEmL4UPE4WrZDuS1OgsLehDw=; b=caagwnpK5lnIBi1dtWQvg0W/ufGG0PfSd7yGgrcp2Hd9PzNk4Q/tfW0Z IECl+LeXOvcnZhlw7SufxV770bA6fZVwtGw+1AB7UkjrTe4H/V95aaAfJ FvzVnRGpK55bwpA9qDEGxrsdHuKtJzF2Owg/uKmQg4laQbU8xB4x5yIMg 8=; X-IronPort-AV: E=Sophos;i="5.67,269,1566864000"; d="scan'208";a="420684493" Received: from iad6-co-svc-p1-lb1-vlan3.amazon.com (HELO email-inbound-relay-1a-67b371d8.us-east-1.amazon.com) ([10.124.125.6]) by smtp-border-fw-out-6001.iad6.amazon.com with ESMTP; 07 Oct 2019 22:11:28 +0000 Received: from EX13MTAUWB001.ant.amazon.com (iad55-ws-svc-p15-lb9-vlan3.iad.amazon.com [10.40.159.166]) by email-inbound-relay-1a-67b371d8.us-east-1.amazon.com (Postfix) with ESMTPS id ACA92A212F; Mon, 7 Oct 2019 22:11:27 +0000 (UTC) Received: from EX13D01UWB001.ant.amazon.com (10.43.161.75) by EX13MTAUWB001.ant.amazon.com (10.43.161.207) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 7 Oct 2019 22:11:27 +0000 Received: from EX13D01UWB003.ant.amazon.com (10.43.161.94) by EX13d01UWB001.ant.amazon.com (10.43.161.75) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 7 Oct 2019 22:11:26 +0000 Received: from EX13D01UWB003.ant.amazon.com ([10.43.161.94]) by EX13d01UWB003.ant.amazon.com ([10.43.161.94]) with mapi id 15.00.1367.000; Mon, 7 Oct 2019 22:11:26 +0000 From: "Singh, Balbir" To: "kbusch@kernel.org" , "hch@lst.de" , "linux-kernel@vger.kernel.org" , "linux-nvme@lists.infradead.org" , "tyaramer@gmail.com" , "axboe@fb.com" , "sagi@grimberg.me" Subject: Re: [PATCH] nvme-pci: Shutdown when removing dead controller Thread-Topic: [PATCH] nvme-pci: Shutdown when removing dead controller Thread-Index: AQHVfVwpGhwUwA6X9kWpqedn8pc+zg== Date: Mon, 7 Oct 2019 22:11:26 +0000 Message-ID: <7042458bf65523747514c98db36ceaa5fa390679.camel@amazon.com> References: <20191003191354.GA4481@Serenity> In-Reply-To: <20191003191354.GA4481@Serenity> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.43.161.7] Content-ID: <95C8F61E4CD0D44AAB11CB3984C122A6@amazon.com> MIME-Version: 1.0 Precedence: Bulk X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191007_151131_753813_C60CB1C5 X-CRM114-Status: GOOD ( 16.63 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Thu, 2019-10-03 at 15:13 -0400, Tyler Ramer wrote: > Always shutdown the controller when nvme_remove_dead_controller is > reached. > > It's possible for nvme_remove_dead_controller to be called as part of a > failed reset, when there is a bad NVME_CSTS. The controller won't > be comming back online, so we should shut it down rather than just > disabling. > I would add that nvme_timeout() would go through the nvme_should_reset() path where we don't shutdown the device during nvme_dev_disable, it makes sense to do a full shutdown during nvme_remove_deal_ctrl work() when reset fails. > Signed-off-by: Tyler Ramer > --- Reviewed-by: Balbir Singh > drivers/nvme/host/pci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c > index c0808f9eb8ab..c3f5ba22c625 100644 > --- a/drivers/nvme/host/pci.c > +++ b/drivers/nvme/host/pci.c > @@ -2509,7 +2509,7 @@ static void nvme_pci_free_ctrl(struct nvme_ctrl *ctrl) > static void nvme_remove_dead_ctrl(struct nvme_dev *dev) > { > nvme_get_ctrl(&dev->ctrl); > - nvme_dev_disable(dev, false); > + nvme_dev_disable(dev, true); > nvme_kill_queues(&dev->ctrl); > if (!queue_work(nvme_wq, &dev->remove_work)) > nvme_put_ctrl(&dev->ctrl); _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme