linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: sagi@grimberg.me (Sagi Grimberg)
Subject: [PATCH v3 4/6] nvme-rdma: use rdma connection reject helper functions
Date: Tue, 25 Oct 2016 19:36:25 +0300	[thread overview]
Message-ID: <7191d136-aef4-9fed-223e-f2a9c1d958e5@grimberg.me> (raw)
In-Reply-To: <55638a1d2a9f79af8b9a19eb444c5d0a41691352.1477336045.git.swise@opengridcomputing.com>


> +static const char *const nvme_rdma_cm_status_strs[] = {
> +	[NVME_RDMA_CM_INVALID_LEN]	= "invalid length",
> +	[NVME_RDMA_CM_INVALID_RECFMT]	= "invalid record format",
> +	[NVME_RDMA_CM_INVALID_QID]	= "invalid queue id",
> +	[NVME_RDMA_CM_INVALID_HSQSIZE]	= "invalid host sq size",
> +	[NVME_RDMA_CM_INVALID_HRQSIZE]	= "invalid host rq size",
> +	[NVME_RDMA_CM_NO_RSC]		= "resource not found",
> +	[NVME_RDMA_CM_INVALID_IRD]	= "invalid ird",
> +	[NVME_RDMA_CM_INVALID_ORD]	= "Invalid ord",
> +};

I think it'd be better to move them to include/linux/nvme-rdma.h
and use them for logging on the target side too.

  reply	other threads:[~2016-10-25 16:36 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-24 19:07 [PATCH v3 0/6] connect reject event helpers Steve Wise
2016-10-24 18:59 ` [PATCH v3 1/6] rdma_cm: add rdma_reject_msg() helper function Steve Wise
2016-10-25 16:37   ` Sagi Grimberg
2016-10-25 17:00   ` Christoph Hellwig
2016-10-25 17:58   ` Bart Van Assche
2016-10-25 18:18     ` Steve Wise
2016-10-24 18:59 ` [PATCH v3 2/6] rdma_cm: add rdma_is_consumer_reject() " Steve Wise
2016-10-25 16:36   ` Sagi Grimberg
2016-10-25 17:00   ` Christoph Hellwig
2016-10-24 18:59 ` [PATCH v3 3/6] rdma_cm: add rdma_consumer_reject_data " Steve Wise
2016-10-25 16:36   ` Sagi Grimberg
2016-10-25 17:01   ` Christoph Hellwig
2016-10-24 19:07 ` [PATCH v3 4/6] nvme-rdma: use rdma connection reject helper functions Steve Wise
2016-10-25 16:36   ` Sagi Grimberg [this message]
2016-10-25 16:58     ` Steve Wise
2016-10-25 17:02     ` Christoph Hellwig
2016-10-25 17:04       ` Sagi Grimberg
2016-10-25 17:01   ` Christoph Hellwig
2016-10-25 18:05   ` Bart Van Assche
2016-10-25 18:20     ` Steve Wise
2016-10-25 18:25       ` Bart Van Assche
2016-10-24 19:07 ` [PATCH v3 5/6] ib_iser: log the connection reject message Steve Wise
2016-10-25 16:34   ` Sagi Grimberg
2016-10-24 19:07 ` [PATCH v3 6/6] rds_rdma: " Steve Wise
2016-10-25 15:51   ` Santosh Shilimkar
2016-10-25 16:04     ` Steve Wise
2016-10-25 16:11       ` Santosh Shilimkar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7191d136-aef4-9fed-223e-f2a9c1d958e5@grimberg.me \
    --to=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).