From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Keith Busch <kbusch@kernel.org>
Cc: Varun Prakash <varun@chelsio.com>,
Sagi Grimberg <sagi@grimberg.me>, "hch@lst.de" <hch@lst.de>,
"Ran.Anner@dell.com" <Ran.Anner@dell.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH v4] nvme-tcp: send H2CData PDUs based on MAXH2CDATA
Date: Wed, 2 Mar 2022 01:50:23 +0000 [thread overview]
Message-ID: <71c572bf-e391-fb34-2604-e7cedd55bf98@nvidia.com> (raw)
In-Reply-To: <20220301225601.GA2366101@dhcp-10-100-145-180.wdc.com>
Keith,
On 3/1/22 2:56 PM, Keith Busch wrote:
> On Sun, Feb 20, 2022 at 03:05:18PM +0200, Sagi Grimberg wrote:
>>
>>>> Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
>>>
>>> Let's wait with this for a moment..
>>>
>>> Keith,
>>> Is it possible that you guys take this for a test run?
>>> This is the area that exposed a few issues in the past
>>> working against your target device...
>>>
>>> Ran, maybe you can run it against your target as well?
>>>
>>> Would love to get your tested-by/acked-by tags.
>>
>> I think we can move forward with this patch. If this turns
>> out to cause any issues we can address those as they come...
>
> Hmm, it looks like this triggers the below warning on a disconnect test.
>
If it is not triggered by the blktests then maybe it is worth adding
a testcase for that scenario.
-ck
next prev parent reply other threads:[~2022-03-02 1:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-22 16:57 [PATCH v4] nvme-tcp: send H2CData PDUs based on MAXH2CDATA Varun Prakash
2022-01-23 9:16 ` Sagi Grimberg
2022-01-24 21:11 ` Sagi Grimberg
2022-02-20 13:05 ` Sagi Grimberg
2022-02-22 17:18 ` Christoph Hellwig
2022-02-22 17:19 ` Christoph Hellwig
2022-03-01 22:56 ` Keith Busch
2022-03-02 1:50 ` Chaitanya Kulkarni [this message]
2022-03-04 21:11 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71c572bf-e391-fb34-2604-e7cedd55bf98@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=Ran.Anner@dell.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=varun@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).