From: Tokunori Ikegami <ikegami.t@gmail.com>
To: Keith Busch <kbusch@meta.com>,
linux-nvme@lists.infradead.org, hch@lst.de
Cc: martin.petersen@oracle.com, joshi.k@samsung.com,
Keith Busch <kbusch@kernel.org>, David Wei <dw@davidwei.uk>
Subject: Re: [PATCHv3] nvme: module parameter to disable pi with offsets
Date: Fri, 25 Oct 2024 04:08:10 +0900 [thread overview]
Message-ID: <7220907b-bb97-4ad8-be9d-82c7291e783e@gmail.com> (raw)
In-Reply-To: <20241024154923.3156803-1-kbusch@meta.com>
On 2024/10/25 0:49, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
>
> +module_param(disable_pi_offsets, bool, 0444);
About the naming "disable" is negative meaning so seems better to be a
positive parameter like as "use_pi_offsets", etc. for example. By the
way the permission 0444 is only for reads so is it needed to change the
value by any code change, etc.?
next prev parent reply other threads:[~2024-10-24 19:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-24 15:49 [PATCHv3] nvme: module parameter to disable pi with offsets Keith Busch
2024-10-24 15:53 ` Christoph Hellwig
2024-10-24 16:44 ` Keith Busch
2024-10-24 17:29 ` Kanchan Joshi
2024-10-24 18:11 ` Chaitanya Kulkarni
2024-10-24 19:08 ` Tokunori Ikegami [this message]
2024-10-30 14:18 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7220907b-bb97-4ad8-be9d-82c7291e783e@gmail.com \
--to=ikegami.t@gmail.com \
--cc=dw@davidwei.uk \
--cc=hch@lst.de \
--cc=joshi.k@samsung.com \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-nvme@lists.infradead.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox