From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Hannes Reinecke <hare@suse.de>
Cc: Sagi Grimberg <sagi@grimberg.me>,
Keith Busch <keith.busch@wdc.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
Martin Belanger <martin.belanger@dell.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCHv2] nvme: print out valid arguments when reading from /dev/nvme-fabrics
Date: Mon, 13 Dec 2021 21:47:30 +0000 [thread overview]
Message-ID: <741fd9d9-8411-dadd-96fe-c2e46863d33a@nvidia.com> (raw)
In-Reply-To: <fe706681-4897-6cc7-3595-668fe824a1ed@suse.de>
Can we use "\n" instead of "," ?
>> with that change it looks :-
>>
>> instance=-1,cntlid=-1
>> transport=%s
>> traddr=%s
>> trsvcid=%s
>> nqn=%s
>> queue_size=%d
>> nr_io_queues=%d
>> reconnect_delay=%d
>> ctrl_loss_tmo=%d
>> keep_alive_tmo=%d
>> hostnqn=%s
>> host_traddr=%s
>> host_iface=%s
>> hostid=%s
>> duplicate_connect
>> disable_sqflow
>> hdr_digest
>> data_digest
>> nr_write_queues=%d
>> nr_poll_queues=%d
>> tos=%d
>> fast_io_fail_tmo=%d
>> discovery
>>
> The ',' format is being used for a successful connect, so I'd rather
> stay with that to make parsing easier.
>
hmmm, looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
next prev parent reply other threads:[~2021-12-13 21:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-07 13:55 [PATCHv2] nvme: print out valid arguments when reading from /dev/nvme-fabrics Hannes Reinecke
2021-12-13 8:06 ` Chaitanya Kulkarni
2021-12-13 8:39 ` Hannes Reinecke
2021-12-13 21:47 ` Chaitanya Kulkarni [this message]
2021-12-16 8:37 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=741fd9d9-8411-dadd-96fe-c2e46863d33a@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=keith.busch@wdc.com \
--cc=linux-nvme@lists.infradead.org \
--cc=martin.belanger@dell.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox