public inbox for linux-nvme@lists.infradead.org
 help / color / mirror / Atom feed
From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Christoph Hellwig <hch@lst.de>
Cc: "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	Sagi Grimberg <sagi@grimberg.me>, Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH 1/4] nvme: cleanup __nvme_check_ids
Date: Thu, 24 Feb 2022 22:50:14 +0000	[thread overview]
Message-ID: <749331a2-2dd1-446e-12f5-e74fe3667ed8@nvidia.com> (raw)
In-Reply-To: <20220224192845.1097602-2-hch@lst.de>

On 2/24/22 11:28, Christoph Hellwig wrote:
> Pass the actual nvme_ns_ids used for the comparison instead of the
> ns_head that isn't needed and use a more descriptive function name.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---


Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>



  reply	other threads:[~2022-02-24 23:05 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-24 19:28 properly validate the nvme uniqueue identifiers are unique v2 Christoph Hellwig
2022-02-24 19:28 ` [PATCH 1/4] nvme: cleanup __nvme_check_ids Christoph Hellwig
2022-02-24 22:50   ` Chaitanya Kulkarni [this message]
2022-02-24 19:28 ` [PATCH 2/4] nvme: fix the check for duplicate unique identifiers Christoph Hellwig
2022-02-24 22:51   ` Chaitanya Kulkarni
2022-02-24 19:28 ` [PATCH 3/4] nvme: check for duplicate identifiers earlier Christoph Hellwig
2022-02-24 22:52   ` Chaitanya Kulkarni
2022-02-24 19:28 ` [PATCH 4/4] nvme: check that EUI/GUID/UUID are globally unique Christoph Hellwig
2022-02-24 22:54   ` Chaitanya Kulkarni
2022-04-08  1:04   ` Luis Chamberlain
2022-04-08  5:29     ` Christoph Hellwig
2022-04-08  7:19       ` Klaus Jensen
2022-04-08 16:10         ` Christoph Hellwig
2022-04-08 17:46           ` Luis Chamberlain
2022-04-11  5:05             ` Christoph Hellwig
2022-04-11  5:54               ` Christoph Hellwig
2022-04-11  6:01                 ` Klaus Jensen
2022-04-11  6:09                   ` Christoph Hellwig
2022-04-11  6:11                     ` Klaus Jensen
2022-04-12 18:46                 ` Luis Chamberlain
2022-04-18 23:30                 ` Alan Adamson
2022-04-20  7:36                   ` Christoph Hellwig
2022-06-06 20:35                     ` Alan Adamson
2022-06-06 21:38                       ` Keith Busch
2022-06-06 21:51                         ` Alan Adamson
2022-06-06 21:58                           ` Keith Busch
2022-06-06 23:11                             ` Alan Adamson
2022-06-07 19:01                               ` Keith Busch
2022-06-08  7:48                               ` Christoph Hellwig
2022-06-08  7:52                       ` Christoph Hellwig
2022-06-08 18:11                         ` Alan Adamson
2022-06-08 19:04                           ` Keith Busch
2022-06-09  0:30                             ` Chaitanya Kulkarni
2022-06-09 15:11                               ` Alan Adamson
2022-06-09  3:53                             ` Christoph Hellwig
2022-06-10  0:27                               ` Alan Adamson
2022-06-10 14:12                                 ` Keith Busch
2022-06-15 20:15                                   ` Alan Adamson
2022-06-17  9:01                                     ` Christoph Hellwig
2022-06-21 18:40                                       ` Alan Adamson
2022-06-21 19:11                                         ` Keith Busch
2022-06-21 20:39                                           ` Alan Adamson
2022-06-22 11:00                                           ` Christoph Hellwig
2022-06-22 15:45                                             ` Alan Adamson
2022-02-24 19:38 ` properly validate the nvme uniqueue identifiers are unique v2 Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=749331a2-2dd1-446e-12f5-e74fe3667ed8@nvidia.com \
    --to=chaitanyak@nvidia.com \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox