From: Hannes Reinecke <hare@suse.de>
To: Ming Lei <ming.lei@redhat.com>, Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>
Cc: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>,
Sagi Grimberg <sagi@grimberg.me>, Chao Leng <lengchao@huawei.com>,
Bart Van Assche <bvanassche@acm.org>
Subject: Re: [PATCH V3 4/4] nvme: use blk_mq_[un]quiesce_tagset
Date: Tue, 8 Sep 2020 10:46:23 +0200 [thread overview]
Message-ID: <785e8bc6-99c7-b65b-df89-a41057a11241@suse.de> (raw)
In-Reply-To: <20200908081538.1434936-5-ming.lei@redhat.com>
On 9/8/20 10:15 AM, Ming Lei wrote:
> From: Sagi Grimberg <sagi@grimberg.me>
>
> All controller namespaces share the same tagset, so we
> can use this interface which does the optimal operation
> for parallel quiesce based on the tagset type (e.g.
> blocking tagsets and non-blocking tagsets).
>
> Cc: Sagi Grimberg <sagi@grimberg.me>
> Cc: Bart Van Assche <bvanassche@acm.org>
> Cc: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
> Cc: Chao Leng <lengchao@huawei.com>
>
> Add code to unquiesce ctrl->connect_q in nvme_stop_queues(), meantime
> avoid to call blk_mq_quiesce_tagset()/blk_mq_unquiesce_tagset() if
> this tagset isn't initialized.
> Signed-off-by: Ming Lei <ming.lei@redhat.com>
> Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
> ---
> drivers/nvme/host/core.c | 19 +++++++++----------
> 1 file changed, 9 insertions(+), 10 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
prev parent reply other threads:[~2020-09-08 8:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-08 8:15 [PATCH V3 0/4] blk-mq: implement queue quiesce via percpu_ref for BLK_MQ_F_BLOCKING Ming Lei
2020-09-08 8:15 ` [PATCH V3 1/4] blk-mq: serialize queue quiesce and unquiesce by mutex Ming Lei
2020-09-08 8:38 ` Hannes Reinecke
2020-09-08 11:31 ` Johannes Thumshirn
2020-09-08 17:54 ` Bart Van Assche
2020-09-09 1:16 ` Ming Lei
2020-09-08 8:15 ` [PATCH V3 2/4] blk-mq: implement queue quiesce via percpu_ref for BLK_MQ_F_BLOCKING Ming Lei
2020-09-08 8:44 ` Hannes Reinecke
2020-09-08 9:13 ` Chao Leng
2020-09-08 9:27 ` Ming Lei
2020-09-08 15:31 ` Keith Busch
2020-09-09 1:19 ` Ming Lei
2020-09-08 8:15 ` [PATCH V3 3/4] blk-mq: add tagset quiesce interface Ming Lei
2020-09-08 8:45 ` Hannes Reinecke
2020-09-08 8:15 ` [PATCH V3 4/4] nvme: use blk_mq_[un]quiesce_tagset Ming Lei
2020-09-08 8:46 ` Hannes Reinecke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=785e8bc6-99c7-b65b-df89-a41057a11241@suse.de \
--to=hare@suse.de \
--cc=Johannes.Thumshirn@wdc.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=lengchao@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=ming.lei@redhat.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).