From: Jens Axboe <axboe@kernel.dk>
To: Keith Busch <kbusch@kernel.org>, Ye Bin <yebin@huaweicloud.com>
Cc: hch@lst.de, sagi@grimberg.me, linux-nvme@lists.infradead.org,
yebin10@huawei.com
Subject: Re: [PATCH 2/2] nvme: avoid possible double completions for the same request
Date: Mon, 8 Jun 2026 09:20:49 -0600 [thread overview]
Message-ID: <7aec5240-a09c-4e6b-b65a-6ca5b4b40db6@kernel.dk> (raw)
In-Reply-To: <aibdA7YtCt5OS1EQ@kbusch-mbp>
On 6/8/26 9:17 AM, Keith Busch wrote:
> However, I'm really skeptical controllers actually behave this way.
> You wouldn't have a viable storage device if it was doing this.
Same, and I would be strongly opposed to including theoretical
work-arounds like this that just have fast path overhead for zero gain
on a valid device. If your device is broken, ask the manufacturer to fix
it. Let's please not burden the kernel with catering to broken
implementations.
--
Jens Axboe
next prev parent reply other threads:[~2026-06-08 15:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-08 11:34 [PATCH 0/2] avoid possible double completions for the same request Ye Bin
2026-06-08 11:34 ` [PATCH 1/2] nvme: operate nvme_request->flags with atomic api Ye Bin
2026-06-08 11:34 ` [PATCH 2/2] nvme: avoid possible double completions for the same request Ye Bin
2026-06-08 15:17 ` Keith Busch
2026-06-08 15:20 ` Jens Axboe [this message]
2026-06-09 8:56 ` yebin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7aec5240-a09c-4e6b-b65a-6ca5b4b40db6@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=yebin10@huawei.com \
--cc=yebin@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox