From: Jens Axboe <axboe@kernel.dk>
To: Guixin Liu <kanie@linux.alibaba.com>,
hch@lst.de, sagi@grimberg.me, kch@nvidia.com
Cc: linux-nvme@lists.infradead.org
Subject: Re: [PATCH v2] nvmet-rdma: use sbitmap to replace rsp free list
Date: Tue, 8 Oct 2024 07:31:44 -0600 [thread overview]
Message-ID: <7ba769cd-6707-44cb-afe6-eebb5e75f445@kernel.dk> (raw)
In-Reply-To: <20241008093708.107392-1-kanie@linux.alibaba.com>
On 10/8/24 3:37 AM, Guixin Liu wrote:
> We can use sbitmap to manage all the nvmet_rdma_rsp instead of using
> free lists and spinlock, and we can use an additional tag to
> determine whether the nvmet_rdma_rsp is extra allocated.
>
> In addition, performance has improved:
> 1. testing environment is local rxe rdma devie and mem-based
> backstore device.
> 2. fio command, test the average 5 times:
> fio -filename=/dev/nvme0n1 --ioengine=libaio -direct=1
> -size=1G -name=1 -thread -runtime=60 -time_based -rw=read -numjobs=16
> -iodepth=128 -bs=4k -group_reporting
> 3. Before: 241k IOPS, After: 256k IOPS, an increase of about 5%.
Reviewed-by: Jens Axboe <axboe@kernel.dk>
--
Jens Axboe
next prev parent reply other threads:[~2024-10-08 13:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-08 9:37 [PATCH v2] nvmet-rdma: use sbitmap to replace rsp free list Guixin Liu
2024-10-08 13:31 ` Jens Axboe [this message]
2024-10-08 21:17 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ba769cd-6707-44cb-afe6-eebb5e75f445@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kanie@linux.alibaba.com \
--cc=kch@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox