Re: [RFC PATCH 00/21] block: add and use init tagset helper

Christoph Hellwig
2022-10-10T08:22:53Z

On Fri, Oct 07, 2022 at 11:26:13AM -0700, Luis Chamberlain wrote:
> *If* there were commonalities at init and these could be broken up into
> common groups, each having their own set of calls, then we simplify and
> can abstract these. I say this without doing a complete review of the
> removals, but if there really isn't much of commonalities I tend to
> agree with Bart that open coding this is better.

The commonality is that there are various required or optional
fields to fill out. I actually have a WIP series to make the tag_set
dynamically allocated and refcounted to fix some long standing life time
issues. That creates a new alloc helper that will take a few mandatory
arguments and would heavily clash with this series.