public inbox for linux-nvme@lists.infradead.org
 help / color / mirror / Atom feed
From: Justin Tee <justintee8345@gmail.com>
To: Chaitanya Kulkarni <chaitanyak@nvidia.com>,
	"yi.zhang@redhat.com" <yi.zhang@redhat.com>
Cc: Chaitanya Kulkarni <ckulkarnilinux@gmail.com>,
	"kbusch@kernel.org" <kbusch@kernel.org>,
	"axboe@kernel.dk" <axboe@kernel.dk>, "hch@lst.de" <hch@lst.de>,
	"sagi@grimberg.me" <sagi@grimberg.me>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	"justin.tee@broadcom.com" <justin.tee@broadcom.com>,
	"nareshgottumukkala83@gmail.com" <nareshgottumukkala83@gmail.com>,
	"paul.ely@broadcom.com" <paul.ely@broadcom.com>
Subject: Re: [BUG FIX PATCH COMPILE TESTED ONLY] nvme-fc: release admin tagset if init fails
Date: Thu, 8 Jan 2026 14:49:54 -0800	[thread overview]
Message-ID: <803071b4-6a13-48e1-ba93-c9f57202cb59@gmail.com> (raw)
In-Reply-To: <a2feda48-515d-4e48-876a-01ea6d8d8398@nvidia.com>

 > thanks for looking into this, it was observed when Yi reported the issue.
 >
 > Irrespective of whether it is repro issue, it's still a bug ?
 >
 > Can you please provide review comments ?

Yes, agreed after reviewing the current goto fail_ctrl path that there 
is a missing nvme_remove_admin_tag_set.  I can provide the Reviewed-by 
stamp.

I guess I’d prefer if we can prove this resolves the issue Yi reported.  
If Yi could re-rerun nvme-fc blktests on the original failing setup with 
this patch, that would be great to confirm.

Thanks,
Justin


  reply	other threads:[~2026-01-08 22:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-20  0:18 [BUG FIX PATCH COMPILE TESTED ONLY] nvme-fc: release admin tagset if init fails Chaitanya Kulkarni
2026-01-06 18:28 ` Chaitanya Kulkarni
2026-01-07  1:37   ` Justin Tee
2026-01-08  2:10     ` Chaitanya Kulkarni
2026-01-08 22:49       ` Justin Tee [this message]
2026-01-08 22:51 ` Justin Tee
2026-01-09 14:54 ` Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=803071b4-6a13-48e1-ba93-c9f57202cb59@gmail.com \
    --to=justintee8345@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=chaitanyak@nvidia.com \
    --cc=ckulkarnilinux@gmail.com \
    --cc=hch@lst.de \
    --cc=justin.tee@broadcom.com \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=nareshgottumukkala83@gmail.com \
    --cc=paul.ely@broadcom.com \
    --cc=sagi@grimberg.me \
    --cc=yi.zhang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox