From: Gerd Bayer <gbayer@linux.ibm.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@kernel.dk>,
Sagi Grimberg <sagi@grimberg.me>,
Niklas Schnelle <schnelle@linux.ibm.com>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] nvme-pci: Add debug message on fail to read CSTS
Date: Wed, 22 Oct 2025 10:21:58 +0200 [thread overview]
Message-ID: <80f16787fc36b079b15d3a6bd77084edcbc79554.camel@linux.ibm.com> (raw)
In-Reply-To: <20251022062727.GB4790@lst.de>
On Wed, 2025-10-22 at 08:27 +0200, Christoph Hellwig wrote:
> On Mon, Oct 20, 2025 at 05:29:08PM +0200, Gerd Bayer wrote:
> > diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> > index 7544c4bac2c4a230d32cf729abb9e94bf93a921f..c3b0a9d56ac1f32f67ce0890becd6425eb80ebad 100644
> > --- a/drivers/nvme/host/pci.c
> > +++ b/drivers/nvme/host/pci.c
> > @@ -2906,6 +2906,7 @@ static int nvme_pci_enable(struct nvme_dev *dev)
> > pci_set_master(pdev);
> >
> > if (readl(dev->bar + NVME_REG_CSTS) == -1) {
> > + dev_dbg(dev->ctrl.device, "Read CSTS register failed");
>
> Should this say "reading" instead of "read"? Also most (but not
> all) nvme errors don't start with capitalized words, like most drivers
> as far as I can tell.
I'll change that in a v2.
Thanks,
Gerd
prev parent reply other threads:[~2025-10-22 8:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-20 15:29 [PATCH 0/2] nvme-pci: Log failures to probe Gerd Bayer
2025-10-20 15:29 ` [PATCH 1/2] nvme-pci: Print error message on failure in nvme_probe Gerd Bayer
2025-10-20 23:35 ` Chaitanya Kulkarni
2025-10-21 8:13 ` Gerd Bayer
2025-10-22 6:22 ` Wilfred Mallawa
2025-10-22 6:26 ` Christoph Hellwig
2025-10-22 7:48 ` Greg Kroah-Hartman
2025-10-22 8:20 ` Gerd Bayer
2025-10-20 15:29 ` [PATCH 2/2] nvme-pci: Add debug message on fail to read CSTS Gerd Bayer
2025-10-20 23:34 ` Chaitanya Kulkarni
2025-10-22 6:24 ` Wilfred Mallawa
2025-10-22 6:27 ` Christoph Hellwig
2025-10-22 8:21 ` Gerd Bayer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80f16787fc36b079b15d3a6bd77084edcbc79554.camel@linux.ibm.com \
--to=gbayer@linux.ibm.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=schnelle@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).