From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Christoph Hellwig <hch@lst.de>
Cc: "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"kbusch@kernel.org" <kbusch@kernel.org>,
"sagi@grimberg.me" <sagi@grimberg.me>,
Chaitanya Kulkarni <chaitanyak@nvidia.com>
Subject: Re: [PATCH 5/9] nvme-fc: centralize admin tagset initialization
Date: Wed, 2 Feb 2022 06:46:55 +0000 [thread overview]
Message-ID: <80f3de76-a3c7-f15c-200c-df55c3c2d0bd@nvidia.com> (raw)
In-Reply-To: <20220201081103.GB29769@lst.de>
On 2/1/22 12:11 AM, Christoph Hellwig wrote:
> External email: Use caution opening links or attachments
>
>
> On Fri, Jan 28, 2022 at 01:20:11AM -0800, Chaitanya Kulkarni wrote:
>> + nvme_init_admin_tagset(&(ctrl->admin_tag_set), ctrl,
>
> No need for the braceses.
>
>> + ctrl->ctrl.numa_node, &nvme_fc_admin_mq_ops,
>> + BLK_MQ_F_NO_SCHED, NVMF_RESERVED_TAGS);
>
> But do we need all these args? We should move the admin_tag_sert to the
> generic nvme_ctrl and just pass that and the ops. Everything else
> should be same (I hope it currently is, otherwise we need to fix) or
> easily derivable (e.g. the check if it is fabrics).
>
> Then mve the helper out of line please and convert all callers in one
> patch.
>
Okay, will send out v2 with above comments.
next prev parent reply other threads:[~2022-02-02 6:47 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-28 9:20 [PATCH 0/9] nvme: add helpers and remove duplicate code Chaitanya Kulkarni
2022-01-28 9:20 ` [PATCH 1/9] nvme-fc: add a helper to initialize connect_q Chaitanya Kulkarni
2022-01-28 9:23 ` Chaitanya Kulkarni
2022-01-30 9:44 ` Sagi Grimberg
2022-02-01 8:09 ` Christoph Hellwig
2022-01-28 9:20 ` [PATCH 2/9] nvme-rdma: use " Chaitanya Kulkarni
2022-01-30 9:44 ` Sagi Grimberg
2022-01-28 9:20 ` [PATCH 3/9] nvme-tcp: " Chaitanya Kulkarni
2022-01-30 9:44 ` Sagi Grimberg
2022-01-28 9:20 ` [PATCH 4/9] nvme-loop: " Chaitanya Kulkarni
2022-01-30 9:44 ` Sagi Grimberg
2022-01-28 9:20 ` [PATCH 5/9] nvme-fc: centralize admin tagset initialization Chaitanya Kulkarni
2022-01-28 9:23 ` Chaitanya Kulkarni
2022-01-30 9:47 ` Sagi Grimberg
2022-02-02 6:48 ` Chaitanya Kulkarni
2022-02-01 8:11 ` Christoph Hellwig
2022-02-02 6:46 ` Chaitanya Kulkarni [this message]
2022-01-28 9:20 ` [PATCH 6/9] nvme-pci: use helper for " Chaitanya Kulkarni
2022-01-28 9:20 ` [PATCH 7/9] nvme-rdma: " Chaitanya Kulkarni
2022-01-28 9:20 ` [PATCH 8/9] nvme-tcp: " Chaitanya Kulkarni
2022-01-28 9:20 ` [PATCH 9/9] nvme-loop: " Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80f3de76-a3c7-f15c-200c-df55c3c2d0bd@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).