From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 601EAD5AE66 for ; Thu, 7 Nov 2024 06:20:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qFOXE88NQSLOrED8/j5Bk/3y/66zM7HSoOt1K4NmMuI=; b=CAg1dNhcBdNyxcfYMXNeHGaI9Y rmeGeQI1OqMaqPdcuoCRXAXEzEWLmsmffP3ZCH/9+2xsT+qDRYZFq16jNTsrNyJu1LNQ7vNSiaFJs /El3R1dxGtTRtAWbfVOpl8wKfiIMCbb25aI4JrdXDG8B32hSDo8ycQUPjSTStqQyUHMTm5vbdOiT2 8VDb4COm1IBb28UGgkgGF8Lk2akW2mThYQjUagR7wsfnybE0a4+Cyb08fHa3H8aZ53iJ8oC0jz5OW ZU+TiEoNsQh2FblO+ya1L46eSJO9a0l7qVrXEBFuU57DuS8tMgcdOYa0OcH7yMySvmErkisWuKmmQ 42y3Z+2w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t8vsY-00000005pR1-1Pc3; Thu, 07 Nov 2024 06:20:26 +0000 Received: from out30-112.freemail.mail.aliyun.com ([115.124.30.112]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t8vqj-00000005p3l-0fA4 for linux-nvme@lists.infradead.org; Thu, 07 Nov 2024 06:18:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1730960310; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=qFOXE88NQSLOrED8/j5Bk/3y/66zM7HSoOt1K4NmMuI=; b=g3QOhAtqP/bhcY6qTk3sANne2tjUFFMdMcqw5tuM+1yEYLpKGRrx2tkLi1rnWCgqxB/NuU61XuYDif8iGKM0YS3LgxSB1pZ1FKm1GjmlRISq1X1MFRVTS9RZkqLgdg8mPIKPe+q/y6hYeacQDLG/DEy74mSnOysWhXo+ve8/IZc= Received: from 30.178.82.60(mailfrom:kanie@linux.alibaba.com fp:SMTPD_---0WIuSpZo_1730960307 cluster:ay36) by smtp.aliyun-inc.com; Thu, 07 Nov 2024 14:18:28 +0800 Message-ID: <81fa2aef-9ada-4cea-8731-476883ba2f6d@linux.alibaba.com> Date: Thu, 7 Nov 2024 14:18:26 +0800 MIME-Version: 1.0 User-Agent: =?UTF-8?B?TW96aWxsYSBUaHVuZGVyYmlyZCDmtYvor5XniYg=?= Subject: Re: [PATCH v2] nvme: check at least one ns identification reported To: Christoph Hellwig Cc: kbusch@kernel.org, axboe@kernel.dk, sagi@grimberg.me, linux-nvme@lists.infradead.org References: <20241104031418.121235-1-kanie@linux.alibaba.com> <20241104131529.GA14373@lst.de> <20241107052836.GA1947@lst.de> From: Guixin Liu In-Reply-To: <20241107052836.GA1947@lst.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241106_221833_499740_74923E32 X-CRM114-Status: GOOD ( 14.36 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org 在 2024/11/7 13:28, Christoph Hellwig 写道: > On Wed, Nov 06, 2024 at 06:47:43PM +0800, Guixin Liu wrote: >> I assume that the dm-multipath > dm-multipath is not supported with nvme.. Dm-multipath can be configured to support nvme, /etc/multipath.conf:     devices {         device {                 vendor "NVME"                 product ".*"                 path_grouping_policy group_by_prio         }     } Here is the result of "multipath -l": uuid.a2c24be7-ed8e-4033-9f26-5b9f230265fb dm-0NVME,Linux size=1.0G features='0' hwhandler='0' wp=rw `-+- policy='service-time 0' prio=0 status=active   |- 0:1:2:1 nvme0n2 259:0 active undef running   `- 1:2:2:1 nvme1n2 259:3 active undef running If the target haven't report any indentification, the dm-multipath will use wwid which generated by nvme host driver to recognize which namespaces should be merged. Here is the result of "multipath -l", if we dont report any identification: nvme.0000-6135363837366563633830646133663261643034-4c696e7578-00000001 dm-0 NVME,Linux size=1.0G features='0' hwhandler='0' wp=rw `-+- policy='service-time 0' prio=0 status=active   |- 0:1:1:1 nvme0n1 259:0 active undef running   `- 1:2:1:1 nvme1n1 259:3 active undef running >> will not recognize nvme device if nothing to >> return, > But more importantly the user of the sysfs files is the right place > the just check for these values being non-present. As said before > it's perfectly valid for 1.0 devices so they have to cope with it > anyway. I don't think a message in the kernel log that is very to > process algorithmically is not very useful. > > (I really with we'd have useful and required identifiers from the > start, but that's a separate discussion) Agree, I just worry about that some components denpend on this, currently, no problem. Best Regards, Guixin Liu