From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 02420C46CD2 for ; Wed, 24 Jan 2024 06:11:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Ua+VdJ2UQxBgQh0LDzAaAFUIYy6hxYHokKGdi/rYbbs=; b=IvRIttQYtBbzoco+lICCB8wPvY wNe86EA6uu2qtmqXgxFqARhnWbHitBFQTT98T5NGH00H9MQqd9CWXQOw0r9IIKcR6lLzv3AzLiS1y lIF5kJSjOI3TYONwB0+ObEeYYMFZcWkCm/Ei/NP1Tlkj908a/OZaNL3ktFWUQf6gRb8QWzXgBbrYx YS42Xz91ZpcezDEB5Vz4/y+hG8zvpVJtSicfFoCII2RkDDZ94Ds7j+pKkd/2KVWkRFRjIU9T27yFx yGlEmRlKcwhxJpXQcOigGywdi25OthVjFvsHZ7ew5yyOvYEWJ16Ey16yyksjeMNRFcK9wfkiOAzaw a0i4uX5w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rSWUL-001gkc-1g; Wed, 24 Jan 2024 06:11:53 +0000 Received: from smtp-out1.suse.de ([2a07:de40:b251:101:10:150:64:1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rSWUI-001gjq-0c for linux-nvme@lists.infradead.org; Wed, 24 Jan 2024 06:11:51 +0000 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D3B4B21EDD; Wed, 24 Jan 2024 06:11:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1706076708; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ua+VdJ2UQxBgQh0LDzAaAFUIYy6hxYHokKGdi/rYbbs=; b=135ghavuSSLb/qgempi40IBLCibJuZ5+meq2+utUBAA7agseEalaJg2PNFjCc0KRU1qXVL T12qGGtPSZcQ8c6GaMEVorQppQp/FqefVlGMaNyLrKdMoPuE7Wf0nz2wpMY6OG0j5o8Azy YKc3z/xGuWuBDMQV8wExUHzmDJ5ACoE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1706076708; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ua+VdJ2UQxBgQh0LDzAaAFUIYy6hxYHokKGdi/rYbbs=; b=B/5mky08MDidi3jQWb3LjGouBXZfE0mejA6B7dtCuPa90aiooViZl+zOkSZD0mmAviKKKp s56Me8HQkaNIeCCg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1706076708; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ua+VdJ2UQxBgQh0LDzAaAFUIYy6hxYHokKGdi/rYbbs=; b=135ghavuSSLb/qgempi40IBLCibJuZ5+meq2+utUBAA7agseEalaJg2PNFjCc0KRU1qXVL T12qGGtPSZcQ8c6GaMEVorQppQp/FqefVlGMaNyLrKdMoPuE7Wf0nz2wpMY6OG0j5o8Azy YKc3z/xGuWuBDMQV8wExUHzmDJ5ACoE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1706076708; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ua+VdJ2UQxBgQh0LDzAaAFUIYy6hxYHokKGdi/rYbbs=; b=B/5mky08MDidi3jQWb3LjGouBXZfE0mejA6B7dtCuPa90aiooViZl+zOkSZD0mmAviKKKp s56Me8HQkaNIeCCg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 486DE1333E; Wed, 24 Jan 2024 06:11:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap1.dmz-prg2.suse.org with ESMTPSA id qGpyDCSqsGVVRwAAD6G6ig (envelope-from ); Wed, 24 Jan 2024 06:11:48 +0000 Message-ID: <822f3536-26fa-4e5f-b87d-94be9209c16e@suse.de> Date: Wed, 24 Jan 2024 07:11:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 06/15] nvme: remove the hack to not update the discard limits in nvme_config_discard Content-Language: en-US To: Christoph Hellwig , Jens Axboe Cc: "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , Paolo Bonzini , Stefan Hajnoczi , "Martin K. Petersen" , Damien Le Moal , Keith Busch , Sagi Grimberg , linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, virtualization@lists.linux.dev References: <20240122173645.1686078-1-hch@lst.de> <20240122173645.1686078-7-hch@lst.de> From: Hannes Reinecke In-Reply-To: <20240122173645.1686078-7-hch@lst.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Authentication-Results: smtp-out1.suse.de; none X-Spamd-Result: default: False [-0.40 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; XM_UA_NO_VERSION(0.01)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; BAYES_HAM(-0.31)[75.35%]; MIME_GOOD(-0.10)[text/plain]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCPT_COUNT_TWELVE(0.00)[14]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email,lst.de:email]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240123_221150_376473_C121DCD9 X-CRM114-Status: GOOD ( 11.23 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On 1/22/24 18:36, Christoph Hellwig wrote: > Now that the block layer tracks a separate user max discard limit, there > is no need to prevent nvme from updating it on controller capability > changes. > > Signed-off-by: Christoph Hellwig > --- > drivers/nvme/host/core.c | 10 ---------- > 1 file changed, 10 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), GF: Ivo Totev, Andrew McDonald, Werner Knoblich