Re: [PATCH 2/2] nvme: add missing status values to verbose logging

[Max Gurtovoy <mgurtovoy@nvidia.com>]

On 4/29/2022 9:08 AM, Hannes Reinecke wrote:
> On 4/28/22 11:19, Max Gurtovoy wrote:
>> The following status values were added: NVME_SC_INTERNAL_PATH_ERROR,
>> NVME_SC_CTRL_PATH_ERROR and NVME_SC_HOST_ABORTED_CMD.
>>
>> Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
>> ---
>>   drivers/nvme/host/constants.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/nvme/host/constants.c 
>> b/drivers/nvme/host/constants.c
>> index 6c2aa8eefb55..1dd1d78de295 100644
>> --- a/drivers/nvme/host/constants.c
>> +++ b/drivers/nvme/host/constants.c
>> @@ -154,10 +154,13 @@ static const char * const nvme_statuses[] = {
>>       [NVME_SC_COMPARE_FAILED] = "Compare Failure",
>>       [NVME_SC_ACCESS_DENIED] = "Access Denied",
>>       [NVME_SC_UNWRITTEN_BLOCK] = "Deallocated or Unwritten Logical 
>> Block",
>> +    [NVME_SC_INTERNAL_PATH_ERROR] = "Internal Pathing Error",
>>       [NVME_SC_ANA_PERSISTENT_LOSS] = "Asymmetric Access Persistent 
>> Loss",
>>       [NVME_SC_ANA_INACCESSIBLE] = "Asymmetric Access Inaccessible",
>>       [NVME_SC_ANA_TRANSITION] = "Asymmetric Access Transition",
>> +    [NVME_SC_CTRL_PATH_ERROR] = "Controller Pathing Error",
>>       [NVME_SC_HOST_PATH_ERROR] = "Host Pathing Error",
>> +    [NVME_SC_HOST_ABORTED_CMD] = "Host Aborted Command",
>>   };
>>     const unsigned char *nvme_get_error_status_str(u16 status)
>
> As mentioned, maybe merge with the first patch.
> But that's merely cosmetical.
Thanks.

I'm fine with squashing it to 1 commit if needed.

Or it can be done during the merge to nvme tree.

Christoph, please comment what is preferred ?

>
> Reviewed-by: Hannes Reinecke <hare@suse.de>
>
> Cheers,
>
> Hannes