From: Jens Axboe <axboe@kernel.dk>
To: Mikulas Patocka <mpatocka@redhat.com>,
Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>,
Mike Snitzer <snitzer@kernel.org>,
Milan Broz <gmazyland@gmail.com>
Cc: linux-block@vger.kernel.org, dm-devel@lists.linux.dev,
linux-nvme@lists.infradead.org
Subject: Re: [RFC PATCH 1/2] block: change rq_integrity_vec to respect the iterator
Date: Wed, 15 May 2024 20:30:12 -0600 [thread overview]
Message-ID: <8522af2f-fb97-4d0b-9e38-868c572da18a@kernel.dk> (raw)
In-Reply-To: <c366231-e146-5a2b-1d8a-5936fb2047ca@redhat.com>
On 5/15/24 7:28 AM, Mikulas Patocka wrote:
> @@ -177,9 +177,9 @@ static inline int blk_integrity_rq(struc
> return 0;
> }
>
> -static inline struct bio_vec *rq_integrity_vec(struct request *rq)
> +static inline struct bio_vec rq_integrity_vec(struct request *rq)
> {
> - return NULL;
> + BUG();
> }
> #endif /* CONFIG_BLK_DEV_INTEGRITY */
> #endif /* _LINUX_BLK_INTEGRITY_H */
Let's please not do that. If it's not used outside of
CONFIG_BLK_DEV_INTEGRITY, it should just go away.
--
Jens Axboe
next prev parent reply other threads:[~2024-05-16 2:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-15 13:27 [RFC PATCH 0/2] dm-crypt support for per-sector NVMe metadata Mikulas Patocka
2024-05-15 13:28 ` [RFC PATCH 1/2] block: change rq_integrity_vec to respect the iterator Mikulas Patocka
2024-05-16 2:30 ` Jens Axboe [this message]
2024-05-20 12:53 ` Mikulas Patocka
2024-05-23 14:58 ` [PATCH v2] " Mikulas Patocka
2024-05-23 15:01 ` Jens Axboe
2024-05-23 15:11 ` Mikulas Patocka
2024-05-23 15:22 ` Anuj gupta
2024-05-23 15:33 ` Jens Axboe
2024-05-23 15:48 ` Mikulas Patocka
2024-05-16 8:14 ` [RFC PATCH 1/2] " Ming Lei
2024-05-20 12:42 ` Mikulas Patocka
2024-05-20 13:19 ` Ming Lei
2024-05-15 13:30 ` [RFC PATCH 2/2] dm-crypt: support per-sector NVMe metadata Mikulas Patocka
2024-05-27 22:12 ` [RFC PATCH 0/2] dm-crypt support for " Eric Wheeler
2024-05-28 7:25 ` Milan Broz
2024-05-28 23:55 ` Eric Wheeler
2024-05-28 11:16 ` Mikulas Patocka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8522af2f-fb97-4d0b-9e38-868c572da18a@kernel.dk \
--to=axboe@kernel.dk \
--cc=dm-devel@lists.linux.dev \
--cc=gmazyland@gmail.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mpatocka@redhat.com \
--cc=sagi@grimberg.me \
--cc=snitzer@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox