public inbox for linux-nvme@lists.infradead.org
 help / color / mirror / Atom feed
From: Pankaj Raghav <p.raghav@samsung.com>
To: Damien Le Moal <damien.lemoal@opensource.wdc.com>,
	<jaegeuk@kernel.org>, <axboe@kernel.dk>, <snitzer@kernel.org>,
	<hch@lst.de>, <mcgrof@kernel.org>, <naohiro.aota@wdc.com>,
	<sagi@grimberg.me>, <dsterba@suse.com>,
	<johannes.thumshirn@wdc.com>
Cc: <linux-kernel@vger.kernel.org>, <clm@fb.com>,
	<gost.dev@samsung.com>, <chao@kernel.org>, <josef@toxicpanda.com>,
	<jonathan.derrick@linux.dev>, <agk@redhat.com>,
	<kbusch@kernel.org>, <kch@nvidia.com>,
	<linux-nvme@lists.infradead.org>, <bvanassche@acm.org>,
	<jiangbo.365@bytedance.com>, <matias.bjorling@wdc.com>,
	<linux-block@vger.kernel.org>
Subject: Re: [PATCH 03/16] block: add bdev_zone_no helper
Date: Thu, 28 Apr 2022 17:40:52 +0200	[thread overview]
Message-ID: <858a5977-e54a-dfa2-c627-56db113128f0@samsung.com> (raw)
In-Reply-To: <652c33b5-1d85-e356-05b9-7bd84b768143@opensource.wdc.com>


On 2022-04-28 01:31, Damien Le Moal wrote:

>> +static inline unsigned int bdev_zone_no(struct block_device *bdev, sector_t sec)
>> +{
>> +	struct request_queue *q = bdev_get_queue(bdev);
>> +
>> +	if (q)
> 
> q is never NULL. So this can be simplified to:
> 
That is a good point. I just noticed it in the bdev_get_queue() function
that q can never be NULL. I will fix it up.

All the functions `bdev*` have this pattern, so probably they could be
simplified as well in the future.
> 	return blk_queue_zone_no(bdev_get_queue(bdev), sector);
> 
>> +		return blk_queue_zone_no(q, sec);
>> +	return 0;
>> +}
>> +
>>  static inline unsigned int bdev_max_open_zones(struct block_device *bdev)
>>  {
>>  	struct request_queue *q = bdev_get_queue(bdev);
> 
> 


  reply	other threads:[~2022-04-28 15:41 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20220427160256eucas1p2db2b58792ffc93026d870c260767da14@eucas1p2.samsung.com>
2022-04-27 16:02 ` [PATCH 00/16] support non power of 2 zoned devices Pankaj Raghav
2022-04-27 16:02   ` [PATCH 01/16] block: make blkdev_nr_zones and blk_queue_zone_no generic for npo2 zsze Pankaj Raghav
2022-04-29 17:16     ` Adam Manzanares
2022-05-03 16:37     ` Bart Van Assche
2022-05-03 16:43       ` Damien Le Moal
2022-05-04  8:35       ` Pankaj Raghav
2022-05-04 16:52     ` Hannes Reinecke
2022-04-27 16:02   ` [PATCH 02/16] block: add blk_queue_zone_aligned and bdev_zone_aligned helper Pankaj Raghav
2022-04-27 23:52     ` Bart Van Assche
2022-04-28 15:33       ` Pankaj Raghav
2022-05-04 16:55     ` Hannes Reinecke
2022-04-27 16:02   ` [PATCH 03/16] block: add bdev_zone_no helper Pankaj Raghav
2022-04-27 23:31     ` Damien Le Moal
2022-04-28 15:40       ` Pankaj Raghav [this message]
2022-04-27 23:53     ` Bart Van Assche
2022-04-28 15:34       ` Pankaj Raghav
2022-05-04 16:55     ` Hannes Reinecke
2022-04-27 16:02   ` [PATCH 04/16] block: allow blk-zoned devices to have non-power-of-2 zone size Pankaj Raghav
2022-04-27 23:37     ` Damien Le Moal
2022-04-28 17:29       ` Luis Chamberlain
2022-04-28 19:04       ` Pankaj Raghav
2022-05-04 16:59     ` Hannes Reinecke
2022-05-04 18:46       ` Pankaj Raghav
2022-04-27 16:02   ` [PATCH 05/16] nvme: zns: Allow ZNS drives that have non-power_of_2 " Pankaj Raghav
2022-04-29 17:23     ` Adam Manzanares
2022-05-03 16:50     ` Bart Van Assche
2022-05-04  8:38       ` Pankaj Raghav
2022-05-04 17:03     ` Hannes Reinecke
2022-05-04 18:55       ` Pankaj Raghav
2022-04-27 16:02   ` [PATCH 06/16] nvmet: use blk_queue_zone_no() Pankaj Raghav
2022-04-29 17:27     ` Adam Manzanares
2022-05-03 16:54     ` Bart Van Assche
2022-05-04 17:05     ` Hannes Reinecke
2022-04-27 16:02   ` [PATCH 07/16] btrfs: zoned: Cache superblock location in btrfs_zoned_device_info Pankaj Raghav
2022-04-27 16:02   ` [PATCH 08/16] btrfs: zoned: add generic btrfs helpers for zoned devices Pankaj Raghav
2022-04-27 16:02   ` [PATCH 09/16] btrfs: zoned: Make sb_zone_number function non power of 2 compatible Pankaj Raghav
2022-04-27 16:02   ` [PATCH 10/16] btrfs: zoned: use btrfs zone helpers to support non po2 zoned devices Pankaj Raghav
2022-04-27 16:02   ` [PATCH 11/16] btrfs: zoned: relax the alignment constraint for " Pankaj Raghav
2022-04-27 16:02   ` [PATCH 12/16] zonefs: allow non power of 2 " Pankaj Raghav
2022-04-27 23:39     ` Damien Le Moal
2022-04-28 15:54       ` Pankaj Raghav
2022-04-28 21:49         ` Damien Le Moal
2022-04-29  7:55           ` Pankaj Raghav
2022-04-27 16:02   ` [PATCH 13/16] null_blk: " Pankaj Raghav
2022-04-29 17:30     ` Adam Manzanares
2022-05-03 17:01     ` Bart Van Assche
2022-05-04 17:10     ` Hannes Reinecke
2022-04-27 16:02   ` [PATCH 14/16] f2fs: call bdev_zone_sectors() only once on init_blkz_info() Pankaj Raghav
2022-05-03 20:04     ` Jaegeuk Kim
2022-04-27 16:02   ` [PATCH 15/16] f2fs: ensure only power of 2 zone sizes are allowed Pankaj Raghav
2022-05-03 20:05     ` Jaegeuk Kim
2022-05-04  8:53       ` Pankaj Raghav
2022-04-27 16:02   ` [PATCH 16/16] dm-zoned: " Pankaj Raghav
2022-04-27 23:42     ` Damien Le Moal
2022-04-28 17:34       ` Luis Chamberlain
2022-04-28 21:43         ` Damien Le Moal
2022-04-28 22:06           ` Luis Chamberlain
2022-05-04 17:11     ` Hannes Reinecke
2022-05-02 22:07   ` [PATCH 00/16] support non power of 2 zoned devices Johannes Thumshirn
2022-05-03  9:12     ` Pankaj Raghav
2022-05-04 21:14       ` David Sterba
2022-05-05  7:28         ` Pankaj Raghav

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=858a5977-e54a-dfa2-c627-56db113128f0@samsung.com \
    --to=p.raghav@samsung.com \
    --cc=agk@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=bvanassche@acm.org \
    --cc=chao@kernel.org \
    --cc=clm@fb.com \
    --cc=damien.lemoal@opensource.wdc.com \
    --cc=dsterba@suse.com \
    --cc=gost.dev@samsung.com \
    --cc=hch@lst.de \
    --cc=jaegeuk@kernel.org \
    --cc=jiangbo.365@bytedance.com \
    --cc=johannes.thumshirn@wdc.com \
    --cc=jonathan.derrick@linux.dev \
    --cc=josef@toxicpanda.com \
    --cc=kbusch@kernel.org \
    --cc=kch@nvidia.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=matias.bjorling@wdc.com \
    --cc=mcgrof@kernel.org \
    --cc=naohiro.aota@wdc.com \
    --cc=sagi@grimberg.me \
    --cc=snitzer@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox