From: Hannes Reinecke <hare@suse.de>
To: Daniel Wagner <dwagner@suse.de>, linux-nvme@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, Keith Busch <kbusch@kernel.org>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Max Gurtovoy <mgurtovoy@nvidia.com>,
Chaitanya Kulkarni <chaitanyak@nvidia.com>
Subject: Re: [PATCH v6 2/6] nvme: refactor ns info helpers
Date: Tue, 19 Dec 2023 12:57:06 +0100 [thread overview]
Message-ID: <863fd40b-c702-4450-a136-d47567080bd7@suse.de> (raw)
In-Reply-To: <20231218165954.29652-3-dwagner@suse.de>
On 12/18/23 17:59, Daniel Wagner wrote:
> Pass in the nvme_ns_head pointer directly. This reduces the necessity on
> the caller side have the nvme_ns data structure present. Thus we can
> refactor the caller side in the next step as well.
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
> Signed-off-by: Daniel Wagner <dwagner@suse.de>
> ---
> drivers/nvme/host/core.c | 36 +++++++++++++++++++++---------------
> drivers/nvme/host/nvme.h | 12 ++++++------
> drivers/nvme/host/rdma.c | 2 +-
> drivers/nvme/host/zns.c | 12 ++++++------
> 4 files changed, 34 insertions(+), 28 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Ivo Totev, Andrew McDonald,
Werner Knoblich
next prev parent reply other threads:[~2023-12-19 11:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-18 16:59 [PATCH v6 0/6] nvme: add csi, ms and nuse to sysfs Daniel Wagner
2023-12-18 16:59 ` [PATCH v6 1/6] nvme: move ns id info to struct nvme_ns_head Daniel Wagner
2023-12-19 11:56 ` Hannes Reinecke
2023-12-19 12:54 ` Sagi Grimberg
2023-12-18 16:59 ` [PATCH v6 2/6] nvme: refactor ns info helpers Daniel Wagner
2023-12-19 11:57 ` Hannes Reinecke [this message]
2023-12-18 16:59 ` [PATCH v6 3/6] nvme: refactor ns info setup function Daniel Wagner
2023-12-19 11:57 ` Hannes Reinecke
2023-12-18 16:59 ` [PATCH v6 4/6] nvme: rename ns attribute group Daniel Wagner
2023-12-19 11:58 ` Hannes Reinecke
2023-12-18 16:59 ` [PATCH v6 5/6] nvme: add csi, ms and nuse to sysfs Daniel Wagner
2023-12-19 11:58 ` Hannes Reinecke
2023-12-18 16:59 ` [PATCH v6 6/6] nvme: repack struct nvme_ns_head Daniel Wagner
2023-12-19 11:59 ` Hannes Reinecke
2023-12-18 22:55 ` [PATCH v6 0/6] nvme: add csi, ms and nuse to sysfs Keith Busch
2023-12-19 14:42 ` Max Gurtovoy
2023-12-19 16:07 ` Keith Busch
2023-12-19 16:26 ` Max Gurtovoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=863fd40b-c702-4450-a136-d47567080bd7@suse.de \
--to=hare@suse.de \
--cc=chaitanyak@nvidia.com \
--cc=dwagner@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mgurtovoy@nvidia.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox