From: Yi Zhang <yi.zhang@redhat.com>
To: Bart Van Assche <bvanassche@acm.org>, osandov@osandov.com
Cc: linux-block@vger.kernel.org, sagi@grimberg.me,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH V2 blktests 3/5] nvmeof-mp/012, srp/012: fix the scheduler list
Date: Thu, 26 Nov 2020 14:16:18 +0800 [thread overview]
Message-ID: <86f0b36c-b484-ee4e-26cd-d5dde35a46eb@redhat.com> (raw)
In-Reply-To: <7fb6260a-4e3d-f023-7471-266188771f39@acm.org>
On 11/26/20 11:59 AM, Bart Van Assche wrote:
> On 11/24/20 11:32 PM, Yi Zhang wrote:
>> +# Get block dev scheduler list
>> +get_scheduler_list() {
>> + local b=$1 p
>> + p=/sys/block/"$b"/queue/scheduler
>> + if [ -e "$p" ]; then
>> + scheds=$(sed 's/[][]//g' /sys/block/"$b"/queue/scheduler)
>> + echo "$scheds"
>> + else
>> + return 1
>> + fi
>> +}
> Can the echo statement and the 'scheds' assignment be left out? This is
> what I have in mind:
Sure, will update with V3.
> sed 's/[][]//g' /sys/block/"$b"/queue/scheduler
>
> Otherwise this patch looks good to me.
>
> Thanks,
>
> Bart.
>
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-11-26 6:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-25 7:32 [PATCH V2 blktests 0/5] nvmeof-mp/srp/nvme-rdma misc fix and enhancement Yi Zhang
2020-11-25 7:32 ` [PATCH V2 blktests 1/5] tests/srp/rc: update the ib_srpt module name Yi Zhang
2020-11-26 3:53 ` Bart Van Assche
2020-11-25 7:32 ` [PATCH V2 blktests 2/5] tests/nvmeof-mp/rc: run nvmeof-mp tests if we set multipath=N Yi Zhang
2020-11-26 3:54 ` Bart Van Assche
2020-11-25 7:32 ` [PATCH V2 blktests 3/5] nvmeof-mp/012, srp/012: fix the scheduler list Yi Zhang
2020-11-26 3:59 ` Bart Van Assche
2020-11-26 6:16 ` Yi Zhang [this message]
2020-11-25 7:32 ` [PATCH V2 blktests 4/5] common/rc: _have_iproute2 fix for "ip -V" change Yi Zhang
2020-11-25 7:32 ` [PATCH V2 blktests 5/5] common/multipath-over-rdma: allow to set use_siw Yi Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86f0b36c-b484-ee4e-26cd-d5dde35a46eb@redhat.com \
--to=yi.zhang@redhat.com \
--cc=bvanassche@acm.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=osandov@osandov.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).