* nvme_change_ctrl_state() bug?
@ 2016-08-12 17:28 Steve Wise
2016-08-12 17:40 ` Gabriel Krisman Bertazi
0 siblings, 1 reply; 2+ messages in thread
From: Steve Wise @ 2016-08-12 17:28 UTC (permalink / raw)
Shouldn't the assigning of the state be inside the lock?
.
spin_unlock_irq(&ctrl->lock);
if (changed)
ctrl->state = new_state;
return changed;
^ permalink raw reply [flat|nested] 2+ messages in thread
* nvme_change_ctrl_state() bug?
2016-08-12 17:28 nvme_change_ctrl_state() bug? Steve Wise
@ 2016-08-12 17:40 ` Gabriel Krisman Bertazi
0 siblings, 0 replies; 2+ messages in thread
From: Gabriel Krisman Bertazi @ 2016-08-12 17:40 UTC (permalink / raw)
"Steve Wise" <swise at opengridcomputing.com> writes:
> Shouldn't the assigning of the state be inside the lock?
Yes, I sent a patch for it, but it hasn't been accepted yet.
http://lists.infradead.org/pipermail/linux-nvme/2016-July/005551.html
--
Gabriel Krisman Bertazi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-12 17:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-12 17:28 nvme_change_ctrl_state() bug? Steve Wise
2016-08-12 17:40 ` Gabriel Krisman Bertazi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).