From: krisman@linux.vnet.ibm.com (Gabriel Krisman Bertazi)
Subject: [PATCH 2/2] nvme: Delete created IO queues on reset
Date: Wed, 05 Oct 2016 22:47:33 -0300 [thread overview]
Message-ID: <87eg3ui6yy.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <1475699566-5284-2-git-send-email-keith.busch@intel.com> (Keith Busch's message of "Wed, 5 Oct 2016 16:32:46 -0400")
Keith Busch <keith.busch at intel.com> writes:
> Commit c21377f8 (Suspend all queues before deletion) decrements the
> online queue count prior to our attempt to delete those IO queues, so
> the driver ended up not having the controller delete any. This patch
> uses the queue_count instead of online_queues.
hmm, this is obviously correct. Nice catch. Shame I missed it :(
Reviewed-by: Gabriel Krisman Bertazi <krisman at linux.vnet.ibm.com>
>
> Signed-off-by: Keith Busch <keith.busch at intel.com>
> ---
> drivers/nvme/host/pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index 108d301..670f0cb 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -1512,7 +1512,7 @@ static int nvme_delete_queue(struct nvme_queue *nvmeq, u8 opcode)
>
> static void nvme_disable_io_queues(struct nvme_dev *dev)
> {
> - int pass, queues = dev->online_queues - 1;
> + int pass, queues = dev->queue_count - 1;
> unsigned long timeout;
> u8 opcode = nvme_admin_delete_sq;
--
Gabriel Krisman Bertazi
next prev parent reply other threads:[~2016-10-06 1:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-05 20:32 [PATCH 1/2] nvme: don't schedule multiple resets Keith Busch
2016-10-05 20:32 ` [PATCH 2/2] nvme: Delete created IO queues on reset Keith Busch
2016-10-05 22:58 ` Sagi Grimberg
2016-10-06 1:47 ` Gabriel Krisman Bertazi [this message]
2016-10-06 9:32 ` Christoph Hellwig
2016-10-06 15:23 ` Keith Busch
2016-10-05 22:57 ` [PATCH 1/2] nvme: don't schedule multiple resets Sagi Grimberg
2016-10-06 9:34 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eg3ui6yy.fsf@linux.vnet.ibm.com \
--to=krisman@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).