Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Corbet <corbet@lwn.net>
To: Guixin Liu <kanie@linux.alibaba.com>,
	Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@kernel.dk>,
	Christoph Hellwig <hch@lst.de>,
	Chaitanya Kulkarni <kch@nvidia.com>
Cc: linux-nvme@lists.infradead.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH separete v2] docs, nvme: introduce nvme-multipath document
Date: Fri, 06 Dec 2024 07:42:58 -0700	[thread overview]
Message-ID: <87frn0vpn1.fsf@trenco.lwn.net> (raw)
In-Reply-To: <20241206072507.37818-1-kanie@linux.alibaba.com>

Guixin Liu <kanie@linux.alibaba.com> writes:

> This adds a document about nvme-multipath and policies supported
> by the Linux NVMe host driver, and also each policy's best scenario.
>
> Signed-off-by: Guixin Liu <kanie@linux.alibaba.com>
> ---
> Hi,
>   We found that we should take care of the throughput of each path in
> service-time policy, so separate the doc patch. And continue working
> on service-time policy patch.
>
> Changes from v1 to v2:
> - Remove service-tome policy.
>
>  Documentation/nvme/nvme-multipath.rst | 72 +++++++++++++++++++++++++++
>  1 file changed, 72 insertions(+)
>  create mode 100644 Documentation/nvme/nvme-multipath.rst

Thanks for working to improve our documentation.

When you add a new file, you need to add it to the relevant index.rst
file as well; if you had run a docs build, you would have seen a warning
about this.

I would also suggest that this material perhaps belongs in the admin
guide rather than in its own directory?

Thanks,

jon


  reply	other threads:[~2024-12-06 14:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-06  7:25 [PATCH separete v2] docs, nvme: introduce nvme-multipath document Guixin Liu
2024-12-06 14:42 ` Jonathan Corbet [this message]
2024-12-09  1:34   ` Guixin Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87frn0vpn1.fsf@trenco.lwn.net \
    --to=corbet@lwn.net \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=kanie@linux.alibaba.com \
    --cc=kbusch@kernel.org \
    --cc=kch@nvidia.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox