From: Jens Axboe <axboe@kernel.dk>
To: Keith Busch <kbusch@kernel.org>, Kanchan Joshi <joshiiitr@gmail.com>
Cc: Kanchan Joshi <joshi.k@samsung.com>,
hch@lst.de, sagi@grimberg.me, linux-nvme@lists.infradead.org,
gost.dev@samsung.com
Subject: Re: [PATCH 0/2] Unprivileged sgl-only passthrough
Date: Wed, 18 Oct 2023 15:08:54 -0600 [thread overview]
Message-ID: <8935bc2e-7d22-4762-b637-7fcf394598e6@kernel.dk> (raw)
In-Reply-To: <ZTBI6FRVCH4Czu13@kbusch-mbp>
On 10/18/23 3:06 PM, Keith Busch wrote:
> On Thu, Oct 19, 2023 at 01:29:46AM +0530, Kanchan Joshi wrote:
>> And if not this, what should be the solution to have non-root
>> passthrough?
>
> I agree we need non-root passthrough.
>
> Could we restore what we previously had, but fence it off with a module
> parameter to opt-in to allow it? Like setting a silicon chicken bit, and
> taint the kernel if that helps convey the responsibility taken with such
> a parameter?
Let's please not do a module parameter, those are just awful to deal
with. I'd much rather see a per-drive toggle for this, which whatever
list could then use. That'd allow you to open the device as root, toggle
the switch per-drive, and then drop caps if that is what your
application does.
I'm going to drop the 6.6 pending bits as, to me, it all seems really
half assed and rushed. Let's just do this right for 6.7, it'll need
backporting anyway.
--
Jens Axboe
prev parent reply other threads:[~2023-10-18 21:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20231018183620epcas5p26ab74bdd1f2739ef3ec1ee2431329dc4@epcas5p2.samsung.com>
2023-10-18 18:30 ` [PATCH 0/2] Unprivileged sgl-only passthrough Kanchan Joshi
2023-10-18 18:30 ` [PATCH 1/2] nvme-pci: meta-transfer via sgl Kanchan Joshi
2023-10-19 5:48 ` Christoph Hellwig
2023-10-19 9:54 ` Kanchan Joshi
2023-10-20 4:40 ` Christoph Hellwig
2023-10-18 18:30 ` [PATCH 2/2] nvme: fine-granular CAP_SYS_ADMIN for nvme io/admin commands Kanchan Joshi
2023-10-19 5:49 ` Christoph Hellwig
2023-10-19 9:59 ` Kanchan Joshi
2023-10-18 18:40 ` [PATCH 0/2] Unprivileged sgl-only passthrough Jens Axboe
2023-10-18 19:06 ` Kanchan Joshi
2023-10-18 19:12 ` Jens Axboe
2023-10-18 19:35 ` Keith Busch
2023-10-18 19:37 ` Jens Axboe
2023-10-18 19:44 ` Kanchan Joshi
2023-10-18 19:47 ` Jens Axboe
2023-10-18 19:59 ` Kanchan Joshi
2023-10-18 21:06 ` Keith Busch
2023-10-18 21:08 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8935bc2e-7d22-4762-b637-7fcf394598e6@kernel.dk \
--to=axboe@kernel.dk \
--cc=gost.dev@samsung.com \
--cc=hch@lst.de \
--cc=joshi.k@samsung.com \
--cc=joshiiitr@gmail.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox