From: jsmart2021@gmail.com (James Smart)
Subject: [PATCH 2/3] nvme_fc: add support for duplicate_connect option
Date: Thu, 19 Oct 2017 08:59:06 -0700 [thread overview]
Message-ID: <89d38cc7-0a6e-d374-4005-96a178a18c78@gmail.com> (raw)
In-Reply-To: <20171019152317.GB4239@infradead.org>
On 10/19/2017 8:23 AM, Christoph Hellwig wrote:
>> +static inline bool
>> +__nvme_fc_options_match(struct nvmf_ctrl_options *opts,
>> + struct nvme_fc_ctrl *ctrl)
>> +{
>> + if (strcmp(opts->subsysnqn, ctrl->ctrl.opts->subsysnqn) ||
>> + strcmp(opts->host->nqn, ctrl->ctrl.opts->host->nqn) ||
>> + memcmp(&opts->host->id, &ctrl->ctrl.opts->host->id,
>> + sizeof(uuid_t)))
>> + return false;
>
> This just checks generic options and isn't FC specific. As a properly
> named helper it might make sense in common code.
>
Agree, I can make a short helper
-- james
next prev parent reply other threads:[~2017-10-19 15:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-11 0:35 [PATCH 0/3] Add duplicate_connect option for ctlr connect requests James Smart
2017-10-11 0:35 ` [PATCH 1/3] nvme: add duplicate_connect option James Smart
2017-10-19 15:20 ` Christoph Hellwig
2017-10-19 15:58 ` James Smart
2017-10-11 0:35 ` [PATCH 2/3] nvme_fc: add support for " James Smart
2017-10-19 15:23 ` Christoph Hellwig
2017-10-19 15:59 ` James Smart [this message]
2017-10-11 0:35 ` [PATCH/RFC 3/3] nvme rdma: " James Smart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89d38cc7-0a6e-d374-4005-96a178a18c78@gmail.com \
--to=jsmart2021@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).