From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: "Ewan D. Milne" <emilne@redhat.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Cc: "tsong@purestorage.com" <tsong@purestorage.com>
Subject: Re: [PATCH 2/3] nvme: multipath: only update ctrl->nr_active when using queue-depth iopolicy
Date: Tue, 7 Nov 2023 21:42:22 +0000 [thread overview]
Message-ID: <89dba91d-5ee1-47aa-8125-dc36285add4f@nvidia.com> (raw)
In-Reply-To: <20231107212331.9413-2-emilne@redhat.com>
> +void nvme_subsys_iopolicy_update(struct nvme_subsystem *subsys, int iopolicy)
> +{
> + struct nvme_ctrl *ctrl;
> +
> + WRITE_ONCE(subsys->iopolicy, iopolicy);
> +
> + mutex_lock(&nvme_subsystems_lock);
> + list_for_each_entry(ctrl, &subsys->ctrls, subsys_entry) {
> + atomic_set(&ctrl->nr_active, 0);
> + }
nit:- do we need braces for above loop ?
-ck
next prev parent reply other threads:[~2023-11-07 21:42 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-07 21:23 [PATCH 1/3] nvme: multipath: Implemented new iopolicy "queue-depth" Ewan D. Milne
2023-11-07 21:23 ` [PATCH 2/3] nvme: multipath: only update ctrl->nr_active when using queue-depth iopolicy Ewan D. Milne
2023-11-07 21:42 ` Chaitanya Kulkarni [this message]
2023-11-07 21:53 ` Keith Busch
2023-11-07 22:03 ` Ewan Milne
2023-11-08 8:09 ` Christoph Hellwig
2023-11-08 16:58 ` John Meneghini
2023-11-08 18:38 ` Ewan Milne
2023-11-10 1:18 ` Uday Shankar
2023-11-13 21:16 ` Ewan Milne
2023-11-07 21:23 ` [PATCH 3/3] nvme: multipath: Invalidate current_path when changing iopolicy Ewan D. Milne
2023-11-08 8:10 ` Christoph Hellwig
2023-11-07 21:40 ` [PATCH 1/3] nvme: multipath: Implemented new iopolicy "queue-depth" Chaitanya Kulkarni
2023-11-07 21:46 ` Chaitanya Kulkarni
2023-11-07 21:56 ` Ewan Milne
2023-11-07 23:32 ` John Meneghini
2023-11-08 4:14 ` Chaitanya Kulkarni
2023-11-07 21:49 ` Keith Busch
2023-11-07 22:01 ` Ewan Milne
2023-11-07 22:14 ` Keith Busch
2024-05-09 20:29 ` [PATCH v2 0/3] nvme: queue-depth multipath iopolicy John Meneghini
2024-05-09 20:29 ` [PATCH v2 1/3] nvme: multipath: Implemented new iopolicy "queue-depth" John Meneghini
2024-05-09 20:29 ` [PATCH v2 2/3] nvme: multipath: only update ctrl->nr_active when using queue-depth iopolicy John Meneghini
2024-05-09 20:29 ` [PATCH v2 3/3] nvme: multipath: Invalidate current_path when changing iopolicy John Meneghini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89dba91d-5ee1-47aa-8125-dc36285add4f@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=emilne@redhat.com \
--cc=linux-nvme@lists.infradead.org \
--cc=tsong@purestorage.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox