Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yi Zhang <yi.zhang@redhat.com>
To: Keith Busch <kbusch@kernel.org>, Sagi Grimberg <sagi@grimberg.me>
Cc: linux-nvme@lists.infradead.org
Subject: Re: incorrect sysfs reported by realpath for nvme disk when nvme-core:multipath enabled
Date: Mon, 16 Sep 2019 17:30:40 +0800	[thread overview]
Message-ID: <8a3ccdd6-ae74-4368-ca64-3e8d47ea72d1@redhat.com> (raw)
In-Reply-To: <20190914151913.GA562@keith-busch>



On 9/14/19 11:19 PM, Keith Busch wrote:
> On Fri, Sep 13, 2019 at 11:43:40AM -0700, Sagi Grimberg wrote:
>>> This was confusing to enough people that we've since changed the naming
>>> to something people expect to see, but that's staged in 5.4. Given the
>>> number of people who find this confusing, this might be worth making a
>>> stable patch.
>> I agree here.

Hi Keith

Thanks for the info, I just test the nvme-5.4, and it works as expect.

[root@rdma-perf-07 ~]$ lsblk
NAME                         MAJ:MIN RM   SIZE RO TYPE MOUNTPOINT
sda                            8:0    0 222.5G  0 disk
├─sda1                         8:1    0   600M  0 part /boot/efi
├─sda2                         8:2    0     1G  0 part /boot
└─sda3                         8:3    0 220.9G  0 part
   ├─rhel_rdma--perf--07-root 253:0    0    50G  0 lvm  /
   ├─rhel_rdma--perf--07-swap 253:1    0     4G  0 lvm  [SWAP]
   └─rhel_rdma--perf--07-home 253:2    0 166.9G  0 lvm  /home
nvme1n1                      259:0    0   1.8T  0 disk
└─nvme1n1p1                  259:1    0   1.8T  0 part
nvme0n1                      259:3    0   1.5T  0 disk
[root@rdma-perf-07 ~]$ realpath /sys/dev/block/259:0
/sys/devices/pci0000:ae/0000:ae:00.0/0000:af:00.0/nvme/nvme1/nvme1n1
[root@rdma-perf-07 ~]$ realpath /sys/dev/block/259:3
/sys/devices/virtual/nvme-subsystem/nvme-subsys0/nvme0n1

Thanks

Yi


> Okay, I'll forward the commit to stable once merged to mainline. I don't
> think we can count on the stable bot to pick this one up. We only need
> this back to 4.19 as all the previous stables with this naming scheme
> have be EOL'ed.
>
> _______________________________________________
> Linux-nvme mailing list
> Linux-nvme@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-nvme


_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

      reply	other threads:[~2019-09-16  9:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1753358694.11967186.1568394608486.JavaMail.zimbra@redhat.com>
2019-09-13 17:40 ` incorrect sysfs reported by realpath for nvme disk when nvme-core:multipath enabled Yi Zhang
2019-09-13 17:56   ` Keith Busch
2019-09-13 18:43     ` Sagi Grimberg
2019-09-14 15:19       ` Keith Busch
2019-09-16  9:30         ` Yi Zhang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8a3ccdd6-ae74-4368-ca64-3e8d47ea72d1@redhat.com \
    --to=yi.zhang@redhat.com \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox