From: "Derrick, Jonathan" <jonathan.derrick@intel.com>
To: "hch@infradead.org" <hch@infradead.org>
Cc: "axboe@fb.com" <axboe@fb.com>,
"sagi@grimberg.me" <sagi@grimberg.me>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"N, Shyjumon" <shyjumon.n@intel.com>,
"Nadolski, Edmund" <edmund.nadolski@intel.com>,
"kbusch@kernel.org" <kbusch@kernel.org>,
"hch@lst.de" <hch@lst.de>
Subject: Re: [PATCH] nvme/pci: Add sleep quirk for Samsung and Toshiba drives
Date: Mon, 3 Feb 2020 16:19:24 +0000 [thread overview]
Message-ID: <8b14347f1a778ae324eb5d950d93fb66a95ab620.camel@intel.com> (raw)
In-Reply-To: <20200130145559.GB8412@infradead.org>
On Thu, 2020-01-30 at 06:55 -0800, Christoph Hellwig wrote:
> On Wed, Jan 22, 2020 at 05:25:26PM +0000, Derrick, Jonathan wrote:
> > That being said, I wonder if there's something else the driver should
> > be doing for the whole range of devices and platform combos that seem
> > to require similar pm quirks.
>
> Well, any idea of what we could do? We're trying to follow the spec
> here, but apparently drivers only get tested with one or two windows
> drivers. We could try to reverse engineer what they do, and given that
> the only one with autonomous is the Intel one, maybe someone from Intel
> could help?
Actually I was simply thinking of code organization. Right now some PM
quirks exist in pci.c and some in core.c. I can't comment on what other
vendors do and we're simply reactive to these issues in the platform.
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
prev parent reply other threads:[~2020-02-03 16:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-21 19:30 [PATCH] nvme/pci: Add sleep quirk for Samsung and Toshiba drives Jon Derrick
2020-01-22 17:25 ` Derrick, Jonathan
2020-01-30 14:55 ` Christoph Hellwig
2020-02-03 16:19 ` Derrick, Jonathan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b14347f1a778ae324eb5d950d93fb66a95ab620.camel@intel.com \
--to=jonathan.derrick@intel.com \
--cc=axboe@fb.com \
--cc=edmund.nadolski@intel.com \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=shyjumon.n@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox