[PATCH] Add quirk for ADATA SX6000PNP

public inbox for linux-nvme@lists.infradead.org
 help / color / mirror / Atom feed

* [PATCH] Add quirk for ADATA SX6000PNP
@ 2022-12-26 14:15 user090909
  2022-12-28 19:20 ` Keith Busch
  2023-02-17 13:27 ` user090909
  0 siblings, 2 replies; 15+ messages in thread
From: user090909 @ 2022-12-26 14:15 UTC (permalink / raw)
  To: busch, axboe, sagi, linux-nvme

From 65e5a06268a4510f2858cbd182dbc60caf7003ff Mon Sep 17 00:00:00 2001
From: user090909 <fuckgithub@riseup.net>
Date: Mon, 26 Dec 2022 17:12:54 +0300
Subject: [PATCH] Add quirk for ADATA SX6000PNP

Signed-off-by: user090909 <fuckgithub@riseup.net>
---
 drivers/nvme/host/pci.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index f0f8027644bb..ca48d0b229e8 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -3415,6 +3415,9 @@ static const struct pci_device_id nvme_id_table[]
= {
 	{ PCI_DEVICE(0x10ec, 0x5762),   /* ADATA SX6000LNP */
 		.driver_data = NVME_QUIRK_IGNORE_DEV_SUBNQN |
 				NVME_QUIRK_BOGUS_NID, },
+	{ PCI_DEVICE(0x10ec, 0x5763),   /* ADATA SX6000PNP */
+                .driver_data = NVME_QUIRK_IGNORE_DEV_SUBNQN |
+                                NVME_QUIRK_BOGUS_NID, },
 	{ PCI_DEVICE(0x1cc1, 0x8201),   /* ADATA SX8200PNP 512GB */
 		.driver_data = NVME_QUIRK_NO_DEEPEST_PS |
 				NVME_QUIRK_IGNORE_DEV_SUBNQN, },
-- 
2.39.0



^ permalink raw reply related	[flat|nested] 15+ messages in thread

* Re: [PATCH] Add quirk for ADATA SX6000PNP
  2022-12-26 14:15 [PATCH] Add quirk for ADATA SX6000PNP user090909
@ 2022-12-28 19:20 ` Keith Busch
  2023-01-08 17:17   ` Christoph Hellwig
  2023-02-17 13:27 ` user090909
  1 sibling, 1 reply; 15+ messages in thread
From: Keith Busch @ 2022-12-28 19:20 UTC (permalink / raw)
  To: user090909; +Cc: axboe, sagi, linux-nvme

On Mon, Dec 26, 2022 at 02:15:39PM +0000, user090909 wrote:
> From 65e5a06268a4510f2858cbd182dbc60caf7003ff Mon Sep 17 00:00:00 2001
> From: user090909 <fuckgithub@riseup.net>
> Date: Mon, 26 Dec 2022 17:12:54 +0300
> Subject: [PATCH] Add quirk for ADATA SX6000PNP
> 
> Signed-off-by: user090909 <fuckgithub@riseup.net>

The sign off is required to use the real name of the patch author.

The patch itself is mangled with line wraps.


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH] Add quirk for ADATA SX6000PNP
  2022-12-28 19:20 ` Keith Busch
@ 2023-01-08 17:17   ` Christoph Hellwig
  0 siblings, 0 replies; 15+ messages in thread
From: Christoph Hellwig @ 2023-01-08 17:17 UTC (permalink / raw)
  To: Keith Busch; +Cc: user090909, axboe, sagi, linux-nvme

On Wed, Dec 28, 2022 at 12:20:24PM -0700, Keith Busch wrote:
> The sign off is required to use the real name of the patch author.
> 
> The patch itself is mangled with line wraps.

Yes.  Also please check with the vendor if there is a firmware update
available first.


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH] Add quirk for ADATA SX6000PNP
  2022-12-26 14:15 [PATCH] Add quirk for ADATA SX6000PNP user090909
  2022-12-28 19:20 ` Keith Busch
@ 2023-02-17 13:27 ` user090909
  1 sibling, 0 replies; 15+ messages in thread
From: user090909 @ 2023-02-17 13:27 UTC (permalink / raw)
  To: busch, axboe, sagi, linux-nvme

[-- Attachment #1: Type: text/plain, Size: 1913 bytes --]

user090909 писал(а) 2022-12-26 17:15:
> From 65e5a06268a4510f2858cbd182dbc60caf7003ff Mon Sep 17 00:00:00 2001
> From: user090909 <fuckgithub@riseup.net>
> Date: Mon, 26 Dec 2022 17:12:54 +0300
> Subject: [PATCH] Add quirk for ADATA SX6000PNP
> 
> Signed-off-by: user090909 <fuckgithub@riseup.net>
> ---
>  drivers/nvme/host/pci.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index f0f8027644bb..ca48d0b229e8 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -3415,6 +3415,9 @@ static const struct pci_device_id nvme_id_table[]
> = {
>  	{ PCI_DEVICE(0x10ec, 0x5762),   /* ADATA SX6000LNP */
>  		.driver_data = NVME_QUIRK_IGNORE_DEV_SUBNQN |
>  				NVME_QUIRK_BOGUS_NID, },
> +	{ PCI_DEVICE(0x10ec, 0x5763),   /* ADATA SX6000PNP */
> +                .driver_data = NVME_QUIRK_IGNORE_DEV_SUBNQN |
> +                                NVME_QUIRK_BOGUS_NID, },
>  	{ PCI_DEVICE(0x1cc1, 0x8201),   /* ADATA SX8200PNP 512GB */
>  		.driver_data = NVME_QUIRK_NO_DEEPEST_PS |
>  				NVME_QUIRK_IGNORE_DEV_SUBNQN, },
This patch doesnt work. Sorry. I send new which work.

Signed-off-by: Ivan Rubinov <linuxkernelpatch8234@riseup.net>

diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index d839689..3f4da40 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -3480,6 +3480,9 @@ static const struct pci_device_id nvme_id_table[]
= {
 	{ PCI_DEVICE(0x10ec, 0x5762),   /* ADATA SX6000LNP */
 		.driver_data = NVME_QUIRK_IGNORE_DEV_SUBNQN |
 				NVME_QUIRK_BOGUS_NID, },
+	{ PCI_DEVICE(0x10ec, 0x5763),   /* ADATA SX6000PNP */
+                .driver_data = NVME_QUIRK_IGNORE_DEV_SUBNQN |
+                                NVME_QUIRK_BOGUS_NID, },
 	{ PCI_DEVICE(0x1cc1, 0x8201),   /* ADATA SX8200PNP 512GB */
 		.driver_data = NVME_QUIRK_NO_DEEPEST_PS |
 				NVME_QUIRK_IGNORE_DEV_SUBNQN, },

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 297cca.patch --]
[-- Type: text/x-diff; name=297cca.patch, Size: 749 bytes --]

Signed-off-by: Ivan Rubinov <linuxkernelpatch8234@riseup.net>

diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index d839689..3f4da40 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -3480,6 +3480,9 @@ static const struct pci_device_id nvme_id_table[] = {
 	{ PCI_DEVICE(0x10ec, 0x5762),   /* ADATA SX6000LNP */
 		.driver_data = NVME_QUIRK_IGNORE_DEV_SUBNQN |
 				NVME_QUIRK_BOGUS_NID, },
+	{ PCI_DEVICE(0x10ec, 0x5763),   /* ADATA SX6000PNP */
+                .driver_data = NVME_QUIRK_IGNORE_DEV_SUBNQN |
+                                NVME_QUIRK_BOGUS_NID, },
 	{ PCI_DEVICE(0x1cc1, 0x8201),   /* ADATA SX8200PNP 512GB */
 		.driver_data = NVME_QUIRK_NO_DEEPEST_PS |
 				NVME_QUIRK_IGNORE_DEV_SUBNQN, },

^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [PATCH] Add quirk for ADATA SX6000PNP
@ 2023-02-10 12:08 Ivan Rubinov
  2023-02-13 10:22 ` Sagi Grimberg
  0 siblings, 1 reply; 15+ messages in thread
From: Ivan Rubinov @ 2023-02-10 12:08 UTC (permalink / raw)
  To: kbusch, axboe, hch, sagi, linux-nvme, linux-kernel

 From 5a8f4f54c85ccb8e06b41b27bcaf19ec4f4d7c85 Mon Sep 17 00:00:00 2001
From: Ivan Rubinov <linuxkernelpatch8234@riseup.net>
Date: Fri, 10 Feb 2023 14:59:41 +0300
Subject: [PATCH] Add quirk for ADATA SX6000PNP

Signed-off-by: Ivan Rubinov <linuxkernelpatch8234@riseup.net>
---
  drivers/nvme/host/pci.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index c734934c407c..c63443d531b3 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -3365,6 +3365,8 @@ static const struct pci_device_id nvme_id_table[] = {
      { PCI_VDEVICE(INTEL, 0x0953),    /* Intel 750/P3500/P3600/P3700 */
          .driver_data = NVME_QUIRK_STRIPE_SIZE |
                  NVME_QUIRK_DEALLOCATE_ZEROES, },
+    { PCI_DEVICE(0x10ec, 0x5763),   /* ADATA SX6000PNP */
+        .driver_data = NVME_QUIRK_IGNORE_DEV_SUBNQN | 
NVME_QUIRK_BOGUS_NID, },
      { PCI_VDEVICE(INTEL, 0x0a53),    /* Intel P3520 */
          .driver_data = NVME_QUIRK_STRIPE_SIZE |
                  NVME_QUIRK_DEALLOCATE_ZEROES, },
-- 
2.39.1



^ permalink raw reply related	[flat|nested] 15+ messages in thread

* Re: [PATCH] Add quirk for ADATA SX6000PNP
  2023-02-10 12:08 Ivan Rubinov
@ 2023-02-13 10:22 ` Sagi Grimberg
  0 siblings, 0 replies; 15+ messages in thread
From: Sagi Grimberg @ 2023-02-13 10:22 UTC (permalink / raw)
  To: Ivan Rubinov, kbusch, axboe, hch, linux-nvme, linux-kernel


> From: Ivan Rubinov <linuxkernelpatch8234@riseup.net>
> Date: Fri, 10 Feb 2023 14:59:41 +0300
> Subject: [PATCH] Add quirk for ADATA SX6000PNP

Is this referencing to a bugzilla or other?

> 
> Signed-off-by: Ivan Rubinov <linuxkernelpatch8234@riseup.net>
> ---
>   drivers/nvme/host/pci.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index c734934c407c..c63443d531b3 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -3365,6 +3365,8 @@ static const struct pci_device_id nvme_id_table[] = {
>       { PCI_VDEVICE(INTEL, 0x0953),    /* Intel 750/P3500/P3600/P3700 */
>           .driver_data = NVME_QUIRK_STRIPE_SIZE |
>                   NVME_QUIRK_DEALLOCATE_ZEROES, },
> +    { PCI_DEVICE(0x10ec, 0x5763),   /* ADATA SX6000PNP */
> +        .driver_data = NVME_QUIRK_IGNORE_DEV_SUBNQN | 
> NVME_QUIRK_BOGUS_NID, },
>       { PCI_VDEVICE(INTEL, 0x0a53),    /* Intel P3520 */
>           .driver_data = NVME_QUIRK_STRIPE_SIZE |
>                   NVME_QUIRK_DEALLOCATE_ZEROES, },


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH] Add quirk for ADATA SX6000PNP
@ 2023-02-10 12:10 Ivan Rubinov
  2023-02-13  6:08 ` Christoph Hellwig
  2023-02-17 13:28 ` Ivan Rubinov
  0 siblings, 2 replies; 15+ messages in thread
From: Ivan Rubinov @ 2023-02-10 12:10 UTC (permalink / raw)
  To: kbusch, axboe, hch, sagi, linux-nvme, linux-kernel

 From 5a8f4f54c85ccb8e06b41b27bcaf19ec4f4d7c85 Mon Sep 17 00:00:00 2001
From: Ivan Rubinov <linuxkernelpatch8234@riseup.net>
Date: Fri, 10 Feb 2023 14:59:41 +0300
Subject: [PATCH] Add quirk for ADATA SX6000PNP

Signed-off-by: Ivan Rubinov <linuxkernelpatch8234@riseup.net>
---
  drivers/nvme/host/pci.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index c734934c407c..c63443d531b3 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -3365,6 +3365,8 @@ static const struct pci_device_id nvme_id_table[] = {
      { PCI_VDEVICE(INTEL, 0x0953),    /* Intel 750/P3500/P3600/P3700 */
          .driver_data = NVME_QUIRK_STRIPE_SIZE |
                  NVME_QUIRK_DEALLOCATE_ZEROES, },
+    { PCI_DEVICE(0x10ec, 0x5763),   /* ADATA SX6000PNP */
+        .driver_data = NVME_QUIRK_IGNORE_DEV_SUBNQN | 
NVME_QUIRK_BOGUS_NID, },
      { PCI_VDEVICE(INTEL, 0x0a53),    /* Intel P3520 */
          .driver_data = NVME_QUIRK_STRIPE_SIZE |
                  NVME_QUIRK_DEALLOCATE_ZEROES, },

-- 
2.39.1



^ permalink raw reply related	[flat|nested] 15+ messages in thread

* Re: [PATCH] Add quirk for ADATA SX6000PNP
  2023-02-10 12:10 Ivan Rubinov
@ 2023-02-13  6:08 ` Christoph Hellwig
  2023-02-13 10:13   ` Daniel Wagner
  2023-02-17 13:28 ` Ivan Rubinov
  1 sibling, 1 reply; 15+ messages in thread
From: Christoph Hellwig @ 2023-02-13  6:08 UTC (permalink / raw)
  To: Ivan Rubinov; +Cc: kbusch, axboe, hch, sagi, linux-nvme, linux-kernel

I've already applied a patch from Daniel Wagner for this device,
but thanks for sending it in!


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH] Add quirk for ADATA SX6000PNP
  2023-02-13  6:08 ` Christoph Hellwig
@ 2023-02-13 10:13   ` Daniel Wagner
       [not found]     ` <a0526a5ef8a1f7bb199231609df7baef@riseup.net>
  0 siblings, 1 reply; 15+ messages in thread
From: Daniel Wagner @ 2023-02-13 10:13 UTC (permalink / raw)
  To: Christoph Hellwig
  Cc: Ivan Rubinov, kbusch, axboe, sagi, linux-nvme, linux-kernel

On Mon, Feb 13, 2023 at 07:08:50AM +0100, Christoph Hellwig wrote:
> I've already applied a patch from Daniel Wagner for this device,
> but thanks for sending it in!

This patch also add NVME_QUIRK_IGNORE_DEV_SUBNQN. Is it necessary?


^ permalink raw reply	[flat|nested] 15+ messages in thread

[parent not found: <a0526a5ef8a1f7bb199231609df7baef@riseup.net>]

* Re: [PATCH] Add quirk for ADATA SX6000PNP
       [not found]     ` <a0526a5ef8a1f7bb199231609df7baef@riseup.net>
@ 2023-02-16 13:25       ` Daniel Wagner
  0 siblings, 0 replies; 15+ messages in thread
From: Daniel Wagner @ 2023-02-16 13:25 UTC (permalink / raw)
  To: soltime; +Cc: linux-nvme@lists.infradead.org

On Thu, Feb 16, 2023 at 07:10:00AM +0000, soltime@riseup.net wrote:
> Daniel Wagner писал(а) 2023-02-13 13:13:
> > On Mon, Feb 13, 2023 at 07:08:50AM +0100, Christoph Hellwig wrote:
> >> I've already applied a patch from Daniel Wagner for this device,
> >> but thanks for sending it in!
> > 
> > This patch also add NVME_QUIRK_IGNORE_DEV_SUBNQN. Is it necessary?
> Yes it is. I tried it without this flag and it doesnt work.

Could you share some logs? I can send an update on my previous patch as it
already merged into Jens' tree.


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH] Add quirk for ADATA SX6000PNP
  2023-02-10 12:10 Ivan Rubinov
  2023-02-13  6:08 ` Christoph Hellwig
@ 2023-02-17 13:28 ` Ivan Rubinov
  2023-02-23 14:53   ` Daniel Wagner
  1 sibling, 1 reply; 15+ messages in thread
From: Ivan Rubinov @ 2023-02-17 13:28 UTC (permalink / raw)
  To: kbusch, axboe, hch, sagi, linux-nvme, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 2015 bytes --]

Ivan Rubinov писал(а) 2023-02-10 15:10:
> From 5a8f4f54c85ccb8e06b41b27bcaf19ec4f4d7c85 Mon Sep 17 00:00:00 2001
> From: Ivan Rubinov <linuxkernelpatch8234@riseup.net>
> Date: Fri, 10 Feb 2023 14:59:41 +0300
> Subject: [PATCH] Add quirk for ADATA SX6000PNP
> 
> Signed-off-by: Ivan Rubinov <linuxkernelpatch8234@riseup.net>
> ---
>  drivers/nvme/host/pci.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index c734934c407c..c63443d531b3 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -3365,6 +3365,8 @@ static const struct pci_device_id nvme_id_table[] = {
>      { PCI_VDEVICE(INTEL, 0x0953),    /* Intel 750/P3500/P3600/P3700 */
>          .driver_data = NVME_QUIRK_STRIPE_SIZE |
>                  NVME_QUIRK_DEALLOCATE_ZEROES, },
> +    { PCI_DEVICE(0x10ec, 0x5763),   /* ADATA SX6000PNP */
> +        .driver_data = NVME_QUIRK_IGNORE_DEV_SUBNQN | NVME_QUIRK_BOGUS_NID, },
>      { PCI_VDEVICE(INTEL, 0x0a53),    /* Intel P3520 */
>          .driver_data = NVME_QUIRK_STRIPE_SIZE |
>                  NVME_QUIRK_DEALLOCATE_ZEROES, },
I am sorry guys its doesnt work. I send new file which work

Signed-off-by: Ivan Rubinov <linuxkernelpatch8234@riseup.net>

diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index d839689..3f4da40 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -3480,6 +3480,9 @@ static const struct pci_device_id nvme_id_table[]
= {
 	{ PCI_DEVICE(0x10ec, 0x5762),   /* ADATA SX6000LNP */
 		.driver_data = NVME_QUIRK_IGNORE_DEV_SUBNQN |
 				NVME_QUIRK_BOGUS_NID, },
+	{ PCI_DEVICE(0x10ec, 0x5763),   /* ADATA SX6000PNP */
+                .driver_data = NVME_QUIRK_IGNORE_DEV_SUBNQN |
+                                NVME_QUIRK_BOGUS_NID, },
 	{ PCI_DEVICE(0x1cc1, 0x8201),   /* ADATA SX8200PNP 512GB */
 		.driver_data = NVME_QUIRK_NO_DEEPEST_PS |
 				NVME_QUIRK_IGNORE_DEV_SUBNQN, },

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 297cca.patch --]
[-- Type: text/x-diff; name=297cca.patch, Size: 749 bytes --]

Signed-off-by: Ivan Rubinov <linuxkernelpatch8234@riseup.net>

diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index d839689..3f4da40 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -3480,6 +3480,9 @@ static const struct pci_device_id nvme_id_table[] = {
 	{ PCI_DEVICE(0x10ec, 0x5762),   /* ADATA SX6000LNP */
 		.driver_data = NVME_QUIRK_IGNORE_DEV_SUBNQN |
 				NVME_QUIRK_BOGUS_NID, },
+	{ PCI_DEVICE(0x10ec, 0x5763),   /* ADATA SX6000PNP */
+                .driver_data = NVME_QUIRK_IGNORE_DEV_SUBNQN |
+                                NVME_QUIRK_BOGUS_NID, },
 	{ PCI_DEVICE(0x1cc1, 0x8201),   /* ADATA SX8200PNP 512GB */
 		.driver_data = NVME_QUIRK_NO_DEEPEST_PS |
 				NVME_QUIRK_IGNORE_DEV_SUBNQN, },

^ permalink raw reply related	[flat|nested] 15+ messages in thread

* Re: [PATCH] Add quirk for ADATA SX6000PNP
  2023-02-17 13:28 ` Ivan Rubinov
@ 2023-02-23 14:53   ` Daniel Wagner
       [not found]     ` <63b276e4-a7eb-f493-fdf7-8dc343aaff50@riseup.net>
  0 siblings, 1 reply; 15+ messages in thread
From: Daniel Wagner @ 2023-02-23 14:53 UTC (permalink / raw)
  To: Ivan Rubinov; +Cc: kbusch, axboe, hch, sagi, linux-nvme, linux-kernel

On Fri, Feb 17, 2023 at 01:28:42PM +0000, Ivan Rubinov wrote:
> Ivan Rubinov писал(а) 2023-02-10 15:10:
> > From 5a8f4f54c85ccb8e06b41b27bcaf19ec4f4d7c85 Mon Sep 17 00:00:00 2001
> > From: Ivan Rubinov <linuxkernelpatch8234@riseup.net>
> > Date: Fri, 10 Feb 2023 14:59:41 +0300
> > Subject: [PATCH] Add quirk for ADATA SX6000PNP
> > 
> > Signed-off-by: Ivan Rubinov <linuxkernelpatch8234@riseup.net>

Can you post the output of 'nvme id-ctrl' for your two devices?
Because the ones in

  https://bugzilla.opensuse.org/show_bug.cgi?id=1207827

clearly have clearly different subnqn.

Although, I have to admint they look suspicious but they are not the same:

subnqn    : nqn.2018-05.com.example:nvme:nvm-subsystem-OUI00E04C2K2129Q696LA
subnqn    : nqn.2018-05.com.example:nvme:nvm-subsystem-OUI00E04C2J4120007707


^ permalink raw reply	[flat|nested] 15+ messages in thread

[parent not found: <63b276e4-a7eb-f493-fdf7-8dc343aaff50@riseup.net>]

* Re: [PATCH] Add quirk for ADATA SX6000PNP
       [not found]     ` <63b276e4-a7eb-f493-fdf7-8dc343aaff50@riseup.net>
@ 2023-02-24  8:57       ` Daniel Wagner
       [not found]         ` <f8ba7be0-37f4-0c5f-373b-2dd3a3a54715@riseup.net>
  0 siblings, 1 reply; 15+ messages in thread
From: Daniel Wagner @ 2023-02-24  8:57 UTC (permalink / raw)
  To: Ivan Rubinov; +Cc: linux-nvme@lists.infradead.org

On Fri, Feb 24, 2023 at 09:45:44AM +0300, Ivan Rubinov wrote:
> (base)  ✘ user@arch  ~  sudo nvme id-ctrl /dev/nvme0
> NVME Identify Controller:
> vid       : 0x10ec
> ssvid     : 0x10ec
> sn        : 2K33292NBAUE
> mn        : ADATA SX6000PNP
> fr        : V9002s94
> rab       : 0
> ieee      : 00e04c
> cmic      : 0
> mdts      : 5
> cntlid    : 0x1
> ver       : 0x10300
> rtd3r     : 0x182b8
> rtd3e     : 0x1e8480
> oaes      : 0
> ctratt    : 0
> rrls      : 0
> cntrltype : 0
> fguid     : 00000000-0000-0000-0000-000000000000
> crdt1     : 0
> crdt2     : 0
> crdt3     : 0
> nvmsr     : 0
> vwci      : 0
> mec       : 0
> oacs      : 0x16
> acl       : 0
> aerl      : 3
> frmw      : 0x2
> lpa       : 0x2
> elpe      : 7
> npss      : 4
> avscc     : 0x1
> apsta     : 0x1
> wctemp    : 373
> cctemp    : 383
> mtfa      : 20
> hmpre     : 16384
> hmmin     : 16384
> tnvmcap   : 0
> unvmcap   : 0
> rpmbs     : 0
> edstt     : 5
> dsto      : 1
> fwug      : 1
> kas       : 0
> hctma     : 0
> mntmt     : 0
> mxtmt     : 0
> sanicap   : 0
> hmminds   : 0
> hmmaxd    : 0
> nsetidmax : 0
> endgidmax : 0
> anatt     : 0
> anacap    : 0
> anagrpmax : 0
> nanagrpid : 0
> pels      : 0
> domainid  : 0
> megcap    : 0
> sqes      : 0x66
> cqes      : 0x44
> maxcmd    : 0
> nn        : 1
> oncs      : 0x14
> fuses     : 0
> fna       : 0
> vwc       : 0x1
> awun      : 0
> awupf     : 0
> icsvscc   : 1
> nwpc      : 0
> acwu      : 0
> ocfs      : 0
> sgls      : 0
> mnan      : 0
> maxdna    : 0
> maxcna    : 0
> subnqn    : nqn.2018-05.com.example:nvme:nvm-subsystem-OUI00E04C2K33292NBAUE
> ioccsz    : 0
> iorcsz    : 0
> icdoff    : 0
> fcatt     : 0
> msdbd     : 0
> ofcs      : 0
> ps      0 : mp:8.00W operational enlat:0 exlat:50000 rrt:0 rrl:0
>             rwt:0 rwl:0 idle_power:- active_power:-
>             active_power_workload:-
> ps      1 : mp:4.00W operational enlat:0 exlat:50000 rrt:1 rrl:1
>             rwt:1 rwl:1 idle_power:- active_power:-
>             active_power_workload:-
> ps      2 : mp:3.00W operational enlat:0 exlat:50000 rrt:2 rrl:2
>             rwt:2 rwl:2 idle_power:- active_power:-
>             active_power_workload:-
> ps      3 : mp:0.0500W non-operational enlat:4000 exlat:50000 rrt:3 rrl:3
>             rwt:3 rwl:3 idle_power:- active_power:-
>             active_power_workload:-
> ps      4 : mp:0.0080W non-operational enlat:8000 exlat:100000 rrt:4 rrl:4
>             rwt:4 rwl:4 idle_power:- active_power:-
>             active_power_workload:-
> (base)  user@arch  ~  sudo nvme id-ctrl /dev/nvme1
> NVME Identify Controller:
> vid       : 0x10ec
> ssvid     : 0x10ec
> sn        : 2K3329Q7H7A2
> mn        : ADATA SX6000PNP
> fr        : V9002s94
> rab       : 0
> ieee      : 00e04c
> cmic      : 0
> mdts      : 5
> cntlid    : 0x1
> ver       : 0x10300
> rtd3r     : 0x182b8
> rtd3e     : 0x1e8480
> oaes      : 0
> ctratt    : 0
> rrls      : 0
> cntrltype : 0
> fguid     : 00000000-0000-0000-0000-000000000000
> crdt1     : 0
> crdt2     : 0
> crdt3     : 0
> nvmsr     : 0
> vwci      : 0
> mec       : 0
> oacs      : 0x16
> acl       : 0
> aerl      : 3
> frmw      : 0x2
> lpa       : 0x2
> elpe      : 7
> npss      : 4
> avscc     : 0x1
> apsta     : 0x1
> wctemp    : 373
> cctemp    : 383
> mtfa      : 20
> hmpre     : 16384
> hmmin     : 16384
> tnvmcap   : 0
> unvmcap   : 0
> rpmbs     : 0
> edstt     : 5
> dsto      : 1
> fwug      : 1
> kas       : 0
> hctma     : 0
> mntmt     : 0
> mxtmt     : 0
> sanicap   : 0
> hmminds   : 0
> hmmaxd    : 0
> nsetidmax : 0
> endgidmax : 0
> anatt     : 0
> anacap    : 0
> anagrpmax : 0
> nanagrpid : 0
> pels      : 0
> domainid  : 0
> megcap    : 0
> sqes      : 0x66
> cqes      : 0x44
> maxcmd    : 0
> nn        : 1
> oncs      : 0x14
> fuses     : 0
> fna       : 0
> vwc       : 0x1
> awun      : 0
> awupf     : 0
> icsvscc   : 1
> nwpc      : 0
> acwu      : 0
> ocfs      : 0
> sgls      : 0
> mnan      : 0
> maxdna    : 0
> maxcna    : 0
> subnqn    : nqn.2018-05.com.example:nvme:nvm-subsystem-OUI00E04C2K3329Q7H7A2
> ioccsz    : 0
> iorcsz    : 0
> icdoff    : 0
> fcatt     : 0
> msdbd     : 0
> ofcs      : 0
> ps      0 : mp:8.00W operational enlat:0 exlat:50000 rrt:0 rrl:0
>             rwt:0 rwl:0 idle_power:- active_power:-
>             active_power_workload:-
> ps      1 : mp:4.00W operational enlat:0 exlat:50000 rrt:1 rrl:1
>             rwt:1 rwl:1 idle_power:- active_power:-
>             active_power_workload:-
> ps      2 : mp:3.00W operational enlat:0 exlat:50000 rrt:2 rrl:2
>             rwt:2 rwl:2 idle_power:- active_power:-
>             active_power_workload:-
> ps      3 : mp:0.0500W non-operational enlat:4000 exlat:50000 rrt:3 rrl:3
>             rwt:3 rwl:3 idle_power:- active_power:-
>             active_power_workload:-
> ps      4 : mp:0.0080W non-operational enlat:8000 exlat:100000 rrt:4 rrl:4
>             rwt:4 rwl:4 idle_power:- active_power:-
>             active_power_workload:-

The subnqn string is used to lookup and uniquely identify a subsys. The two
subnqn are unique and after reading up in the spec (chapter 4.5) they are
valid (the Linux kernel doesn't care about the format as long these strings are
unique).

If the quirk is enabled, the subnqn should be

  nvme0: nqn.2014.08.org.nvmexpress:10ec10ec2K33292NBAUEADATA SX6000PNP
  nvme1: nqn.2014.08.org.nvmexpress:10ec10ec2K3329Q7H7A2ADATA SX6000PNP

without the quirk:

  nvme0: nqn.2018-05.com.example:nvme:nvm-subsystem-OUI00E04C2K33292NBAUE
  nvme1: nqn.2018-05.com.example:nvme:nvm-subsystem-OUI00E04C2K2129Q696LA

And this is all what the quirk does. I must oversee why this is needed.


^ permalink raw reply	[flat|nested] 15+ messages in thread

[parent not found: <f8ba7be0-37f4-0c5f-373b-2dd3a3a54715@riseup.net>]

* Re: [PATCH] Add quirk for ADATA SX6000PNP
       [not found]         ` <f8ba7be0-37f4-0c5f-373b-2dd3a3a54715@riseup.net>
@ 2023-02-27  9:05           ` Daniel Wagner
       [not found]             ` <4a7c105b-f046-3054-a1fd-9441af48b491@riseup.net>
  0 siblings, 1 reply; 15+ messages in thread
From: Daniel Wagner @ 2023-02-27  9:05 UTC (permalink / raw)
  To: Ivan Rubinov; +Cc: linux-nvme@lists.infradead.org

On Sun, Feb 26, 2023 at 01:48:04PM +0300, Ivan Rubinov wrote:
> I run arch linux on live boot without my patch
> kernel-log:
> 
> Feb 26 10:38:28 archiso kernel: nvme nvme0: pci function 0000:01:00.0
> Feb 26 10:38:28 archiso kernel: nvme nvme1: pci function 0000:04:00.0
> Feb 26 10:38:28 archiso kernel: nvme nvme1: failed to set APST feature (2)
> Feb 26 10:38:28 archiso kernel: nvme nvme0: failed to set APST feature (2)
> Feb 26 10:38:28 archiso kernel: nvme nvme1: allocated 64 MiB host memory buffer.
> Feb 26 10:38:28 archiso kernel: nvme nvme0: allocated 64 MiB host memory buffer.
> Feb 26 10:38:28 archiso kernel: nvme nvme1: 7/0/0 default/read/poll queues
> Feb 26 10:38:28 archiso kernel: nvme nvme0: 7/0/0 default/read/poll queues
> Feb 26 10:38:28 archiso kernel: nvme nvme0: globally duplicate IDs for nsid 1
> Feb 26 10:38:28 archiso kernel: nvme nvme0: VID:DID 10ec:5763 model:ADATA SX6000PNP firmware:V9002s94

The duplicate IDs is addressed by NVME_QUIRK_BOGUS_NID. The question is what
happens without the NVME_QUIRK_IGNORE_DEV_SUBNQN quirk. Could you try with
NVME_QUIRK_BOGUS_NID only and post the nvme log output?

Thanks!


^ permalink raw reply	[flat|nested] 15+ messages in thread

[parent not found: <4a7c105b-f046-3054-a1fd-9441af48b491@riseup.net>]

* Re: [PATCH] Add quirk for ADATA SX6000PNP
       [not found]             ` <4a7c105b-f046-3054-a1fd-9441af48b491@riseup.net>
@ 2023-02-28  9:54               ` Daniel Wagner
  0 siblings, 0 replies; 15+ messages in thread
From: Daniel Wagner @ 2023-02-28  9:54 UTC (permalink / raw)
  To: Ivan Rubinov; +Cc: linux-nvme@lists.infradead.org

Hi Ivan,

On Tue, Feb 28, 2023 at 12:10:31PM +0300, Ivan Rubinov wrote:
> With this patch it works nice.
> 
> 
> Signed-off-by: Ivan Rubinov<linuxkernelpatch8234@riseup.net>
> 
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index d839689..3f4da40 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -3480,6 +3480,8 @@ static const struct pci_device_id nvme_id_table[] = {
>      { PCI_DEVICE(0x10ec, 0x5762),   /* ADATA SX6000LNP */
>          .driver_data = NVME_QUIRK_IGNORE_DEV_SUBNQN |
>                  NVME_QUIRK_BOGUS_NID, },
> +    { PCI_DEVICE(0x10ec, 0x5763),   /* ADATA SX6000PNP */
> +                .driver_data = NVME_QUIRK_BOGUS_NID, },
>      { PCI_DEVICE(0x1cc1, 0x8201),   /* ADATA SX8200PNP 512GB */
>          .driver_data = NVME_QUIRK_NO_DEEPEST_PS |
>                  NVME_QUIRK_IGNORE_DEV_SUBNQN, },

Right this is exactly what went in:

5f69f009b7c4 ("nvme-pci: add bogus ID quirk for ADATA SX6000PNP")

> Kernel log:
> 
> [    6.852254] nvme nvme0: pci function 0000:01:00.0
> [    6.855936] nvme nvme1: pci function 0000:04:00.0
> [    7.071947] nvme nvme1: failed to set APST feature (2)
> [    7.073201] nvme nvme0: failed to set APST feature (2)
> [    7.094109] nvme nvme0: allocated 64 MiB host memory buffer.
> [    7.098544] nvme nvme1: allocated 64 MiB host memory buffer.
> [    7.125205] nvme nvme0: 7/0/0 default/read/poll queues
> [    7.128853] nvme nvme1: 7/0/0 default/read/poll queues
> [    7.137040] nvme nvme0: Ignoring bogus Namespace Identifiers
> [    7.140688] nvme nvme1: Ignoring bogus Namespace Identifiers
> [    7.142240]  nvme0n1: p1
> [    7.145537]  nvme1n1: p1 p2

Thanks for double checking. The NVME_QUIRK_IGNORE_DEV_SUBNQN would be necessary
if you see something like this in the log:

  nvme nvme1: ignoring ctrl due to duplicate subnqn (xxx)

Obviously, the absence doesn't mean that these devices do not suffer from the
problem but we usually don't add quirks on suspicions. If the above error
message pops up we can still add the quirk. So all is good after all.

Daniel


^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2023-02-28  9:54 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-26 14:15 [PATCH] Add quirk for ADATA SX6000PNP user090909
2022-12-28 19:20 ` Keith Busch
2023-01-08 17:17   ` Christoph Hellwig
2023-02-17 13:27 ` user090909
  -- strict thread matches above, loose matches on Subject: below --
2023-02-10 12:08 Ivan Rubinov
2023-02-13 10:22 ` Sagi Grimberg
2023-02-10 12:10 Ivan Rubinov
2023-02-13  6:08 ` Christoph Hellwig
2023-02-13 10:13   ` Daniel Wagner
     [not found]     ` <a0526a5ef8a1f7bb199231609df7baef@riseup.net>
2023-02-16 13:25       ` Daniel Wagner
2023-02-17 13:28 ` Ivan Rubinov
2023-02-23 14:53   ` Daniel Wagner
     [not found]     ` <63b276e4-a7eb-f493-fdf7-8dc343aaff50@riseup.net>
2023-02-24  8:57       ` Daniel Wagner
     [not found]         ` <f8ba7be0-37f4-0c5f-373b-2dd3a3a54715@riseup.net>
2023-02-27  9:05           ` Daniel Wagner
     [not found]             ` <4a7c105b-f046-3054-a1fd-9441af48b491@riseup.net>
2023-02-28  9:54               ` Daniel Wagner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox