From: James Smart <jsmart2021@gmail.com>
To: Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>
Cc: Sagi Grimberg <sagi@grimberg.me>,
Chaitanya Kulkarni <kch@nvidia.com>,
Gerd Bayer <gbayer@linux.ibm.com>,
asahi@lists.linux.dev, linux-nvme@lists.infradead.org
Subject: Re: [PATCH 02/13] nvme: move OPAL setup from PCIe to core
Date: Mon, 14 Nov 2022 08:37:48 -0800 [thread overview]
Message-ID: <8ff1226e-d38c-67ee-7c8f-771cad7f99d7@gmail.com> (raw)
In-Reply-To: <20221113161138.883195-3-hch@lst.de>
On 11/13/2022 8:11 AM, Christoph Hellwig wrote:
> Nothing about the TCG Opal support is PCIe transport specific, so move it
> to the core code. For this nvme_init_ctrl_finish grows a new
> was_suspended argument that allows the transport driver to tell the OPAL
> code if the controller came out of a suspend cycle.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Keith Busch <kbusch@kernel.org>
> Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
> Tested-by Gerd Bayer <gbayer@linxu.ibm.com>
> ---
> drivers/nvme/host/apple.c | 2 +-
> drivers/nvme/host/core.c | 25 ++++++++++++++++++++++---
> drivers/nvme/host/fc.c | 2 +-
> drivers/nvme/host/nvme.h | 5 +----
> drivers/nvme/host/pci.c | 14 +-------------
> drivers/nvme/host/rdma.c | 2 +-
> drivers/nvme/host/tcp.c | 2 +-
> drivers/nvme/target/loop.c | 2 +-
> 8 files changed, 29 insertions(+), 25 deletions(-)
>
> diff --git a/drivers/nvme/host/apple.c b/drivers/nvme/host/apple.c
> index 24e224c279a41..a85349a7e938c 100644
Reviewed-by: James Smart <jsmart2021@gmail.com>
-- james
next prev parent reply other threads:[~2022-11-14 16:38 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-13 16:11 nvme-pci: split the probe and reset handlers v2 Christoph Hellwig
2022-11-13 16:11 ` [PATCH 01/13] nvme: don't call nvme_init_ctrl_finish from nvme_passthru_end Christoph Hellwig
2022-11-14 6:25 ` Sagi Grimberg
2022-11-13 16:11 ` [PATCH 02/13] nvme: move OPAL setup from PCIe to core Christoph Hellwig
2022-11-14 16:37 ` James Smart [this message]
2022-11-21 10:28 ` Sagi Grimberg
2022-11-13 16:11 ` [PATCH 03/13] nvme: simplify transport specific device attribute handling Christoph Hellwig
2022-11-13 16:11 ` [PATCH 04/13] nvme-pci: put the admin queue in nvme_dev_remove_admin Christoph Hellwig
2022-11-13 16:11 ` [PATCH 05/13] nvme-pci: move more teardown work to nvme_remove Christoph Hellwig
2022-11-13 16:11 ` [PATCH 06/13] nvme-pci: factor the iod mempool creation into a helper Christoph Hellwig
2022-11-13 16:11 ` [PATCH 07/13] nvme-pci: factor out a nvme_pci_alloc_dev helper Christoph Hellwig
2022-11-13 16:11 ` [PATCH 08/13] nvme-pci: set constant paramters in nvme_pci_alloc_ctrl Christoph Hellwig
2022-11-13 16:11 ` [PATCH 09/13] nvme-pci: call nvme_pci_configure_admin_queue from nvme_pci_enable Christoph Hellwig
2022-11-13 16:11 ` [PATCH 10/13] nvme-pci: simplify nvme_dbbuf_dma_alloc Christoph Hellwig
2022-11-14 6:28 ` Sagi Grimberg
2022-11-13 16:11 ` [PATCH 11/13] nvme-pci: move the HMPRE check into nvme_setup_host_mem Christoph Hellwig
2022-11-14 6:29 ` Sagi Grimberg
2022-11-13 16:11 ` [PATCH 12/13] nvme-pci: split the initial probe from the rest path Christoph Hellwig
2022-11-13 16:11 ` [PATCH 13/13] nvme-pci: don't unbind the driver on reset failure Christoph Hellwig
2022-11-14 6:32 ` Sagi Grimberg
2022-11-14 4:00 ` nvme-pci: split the probe and reset handlers v2 Chaitanya Kulkarni
2022-11-15 9:57 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ff1226e-d38c-67ee-7c8f-771cad7f99d7@gmail.com \
--to=jsmart2021@gmail.com \
--cc=asahi@lists.linux.dev \
--cc=gbayer@linux.ibm.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox