Re: [PATCH 6/8] nvme: fix queue freeze vs limits lock order

Nilay Shroff
2025-01-07T09:29:29Z

On 1/7/25 2:28 PM, Christoph Hellwig wrote:
> On Tue, Jan 07, 2025 at 02:15:05PM +0530, Nilay Shroff wrote:
>> The nvme_set_ctrl_limits() sets certain queue limits which are
>> also used during IO processing. For instance, ->max_segment_size
>> is used while submitting bio.
>
> nvme_set_ctrl_limits only sets them in the on-stack queue_limits
> structure, which is local to the calling thread.
>
>
Oh yeah, I didn't notice it while reading patch. Agreed, we don't
require freezing queue here. Sorry for the noise.

Thanks,
--Nilay