From: James Smart <jsmart2021@gmail.com>
To: Sagi Grimberg <sagi@grimberg.me>, linux-nvme@lists.infradead.org
Cc: Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>,
Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
Martin Belanger <nitram_67@hotmail.com>,
Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH rfc 0/1] Fix missing AENs when discovery controllers are disconnected
Date: Wed, 14 Sep 2022 10:26:35 -0700 [thread overview]
Message-ID: <917848e1-5650-bf1e-7dce-3a994c453c38@gmail.com> (raw)
In-Reply-To: <0d34d7e9-b5e1-149c-aefd-aa3bf182ad94@grimberg.me>
On 9/14/2022 8:31 AM, Sagi Grimberg wrote:
> The fact that the event is called rediscover semantically means that
> this is the discovery controller. It would be weird coming on any other
> controller, even if userspace happened to ask for it. If at all, I'd
> prefer to fail the parameter for controllers that are not discovery
> controller, which is strict, but at least not resulting in a weird
> event...
yeah... I guess I fell into is "rediscover" because the controller was
"rediscovered" on the link ? vs "please rediscover on a discovery
controller"
either way - based on other people's input is fine with me.
-- james
next prev parent reply other threads:[~2022-09-14 17:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-07 14:24 [PATCH rfc 0/1] Fix missing AENs when discovery controllers are disconnected Sagi Grimberg
2022-09-07 14:24 ` [PATCH rfc 1/1] fabrics: support notify_rediscover connect parameter Sagi Grimberg
2022-09-07 14:24 ` [PATCH libnvme 2/1] nvme: Add generic connect parameter support detection Sagi Grimberg
2022-09-09 6:56 ` Daniel Wagner
2022-09-12 12:32 ` Sagi Grimberg
2022-09-12 14:19 ` Daniel Wagner
2022-09-07 14:24 ` [PATCH libnvme 3/1] fabrics: add notify_rediscover parameter Sagi Grimberg
2022-09-09 6:58 ` Daniel Wagner
2022-09-12 12:33 ` Sagi Grimberg
2022-09-12 14:42 ` Daniel Wagner
2022-09-07 14:24 ` [PATCH nvme-cli 4/1] fabrics: re-read the discovery log page when a discovery controller reconnected Sagi Grimberg
2022-09-10 15:47 ` [PATCH rfc 0/1] Fix missing AENs when discovery controllers are disconnected James Smart
2022-09-12 12:39 ` Sagi Grimberg
2022-09-13 0:06 ` James Smart
2022-09-14 10:29 ` Sagi Grimberg
2022-09-14 15:00 ` James Smart
2022-09-14 15:31 ` Sagi Grimberg
2022-09-14 17:26 ` James Smart [this message]
2022-09-18 14:12 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=917848e1-5650-bf1e-7dce-3a994c453c38@gmail.com \
--to=jsmart2021@gmail.com \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=nitram_67@hotmail.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox