From: Hannes Reinecke <hare@suse.de>
To: linux-nvme@lists.infradead.org
Subject: Re: [PATCH v2 2/6] nvme-core: introduce complete failed request
Date: Thu, 21 Jan 2021 09:14:11 +0100 [thread overview]
Message-ID: <93e16361-6973-5245-b040-692ef2ec4d79@suse.de> (raw)
In-Reply-To: <20210107033149.15701-3-lengchao@huawei.com>
On 1/7/21 4:31 AM, Chao Leng wrote:
> When a request is queued failed, if the fail status is not
> BLK_STS_RESOURCE, BLK_STS_DEV_RESOURCE, BLK_STS_ZONE_RESOURCE,
> the request is need to complete with nvme_complete_rq in queue_rq.
> So introduce nvme_try_complete_failed_req.
> The request is needed to complete with NVME_SC_HOST_PATH_ERROR in
> nvmf_fail_nonready_command and queue_rq.
> So introduce nvme_complete_failed_req.
> For details, see the subsequent patches.
>
> Signed-off-by: Chao Leng <lengchao@huawei.com>
> ---
> drivers/nvme/host/nvme.h | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
> diff --git a/drivers/nvme/host/nvme.h b/drivers/nvme/host/nvme.h
> index bfcedfa4b057..fc4eefdfbb34 100644
> --- a/drivers/nvme/host/nvme.h
> +++ b/drivers/nvme/host/nvme.h
> @@ -649,6 +649,27 @@ void nvme_put_ns_from_disk(struct nvme_ns_head *head, int idx);
> extern const struct attribute_group *nvme_ns_id_attr_groups[];
> extern const struct block_device_operations nvme_ns_head_ops;
>
> +static inline void nvme_complete_failed_req(struct request *req)
> +{
> + nvme_req(req)->status = NVME_SC_HOST_PATH_ERROR;
> + blk_mq_set_request_complete(req);
> + nvme_complete_rq(req);
> +}
> +
> +static inline blk_status_t nvme_try_complete_failed_req(struct request *req,
> + blk_status_t ret)
> +{
> + switch (ret) {
> + case BLK_STS_RESOURCE:
> + case BLK_STS_DEV_RESOURCE:
> + case BLK_STS_ZONE_RESOURCE:
> + return ret;
> + default:
> + nvme_complete_failed_req(req);
> + return BLK_STS_OK;
> + }
> +}
> +
> #ifdef CONFIG_NVME_MULTIPATH
> static inline bool nvme_ctrl_use_ana(struct nvme_ctrl *ctrl)
> {
>
This is not correct.
HOST_PATH_ERROR only should be set _iff_ it is a pathing issue, and the
HBA/transport is equipped to determine that.
Any other error have other causes, and we need to look at the individual
error codes (and situations) to determine if this really is a pathing error.
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-01-21 8:14 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-07 3:31 [PATCH v2 0/6] avoid repeated request completion and IO error Chao Leng
2021-01-07 3:31 ` [PATCH v2 1/6] blk-mq: introduce blk_mq_set_request_complete Chao Leng
2021-01-14 0:17 ` Sagi Grimberg
2021-01-14 6:50 ` Chao Leng
2021-01-07 3:31 ` [PATCH v2 2/6] nvme-core: introduce complete failed request Chao Leng
2021-01-21 8:14 ` Hannes Reinecke [this message]
2021-01-22 1:45 ` Chao Leng
2021-01-07 3:31 ` [PATCH v2 3/6] nvme-fabrics: avoid repeated request completion for nvmf_fail_nonready_command Chao Leng
2021-01-07 3:31 ` [PATCH v2 4/6] nvme-rdma: avoid IO error and repeated request completion Chao Leng
2021-01-14 0:19 ` Sagi Grimberg
2021-01-14 6:55 ` Chao Leng
2021-01-14 21:25 ` Sagi Grimberg
2021-01-15 2:53 ` Chao Leng
2021-01-16 1:18 ` Sagi Grimberg
2021-01-18 3:22 ` Chao Leng
2021-01-18 17:49 ` Christoph Hellwig
2021-01-19 1:50 ` Chao Leng
2021-01-20 21:35 ` Sagi Grimberg
2021-01-21 1:34 ` Chao Leng
2021-01-07 3:31 ` [PATCH v2 5/6] nvme-tcp: " Chao Leng
2021-01-07 3:31 ` [PATCH v2 6/6] nvme-fc: " Chao Leng
2021-01-14 0:15 ` [PATCH v2 0/6] avoid repeated request completion and IO error Sagi Grimberg
2021-01-14 6:50 ` Chao Leng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93e16361-6973-5245-b040-692ef2ec4d79@suse.de \
--to=hare@suse.de \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox