Re: [PATCH for-next v10 3/7] nvme: refactor nvme_add_user_metadata

Christoph Hellwig
2022-09-28T17:18:19Z

On Tue, Sep 27, 2022 at 11:06:06PM +0530, Kanchan Joshi wrote:
> if (bdev && meta_buffer && meta_len) {
> - meta = nvme_add_user_metadata(bio, meta_buffer, meta_len,
> - meta_seed, write);
> + meta = nvme_add_user_metadata(req, meta_buffer, meta_len,

Pleae avoid the overly long line here.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>