From: Nilay Shroff <nilay@linux.ibm.com>
To: Keith Busch <kbusch@kernel.org>
Cc: linux-nvme@lists.infradead.org, hch@lst.de, sagi@grimberg.me,
kch@nvidia.com, axboe@fb.com, gjoyce@linux.ibm.com
Subject: Re: [PATCH] nvmet-passthru: allow nvme ns-id descriptor list to clear EUID/NGUID/UUID
Date: Sat, 21 Sep 2024 12:35:58 +0530 [thread overview]
Message-ID: <96531d69-172d-4116-be76-db79085f7fb4@linux.ibm.com> (raw)
In-Reply-To: <Zu2nslMqpfPR9j6f@kbusch-mbp>
On 9/20/24 22:19, Keith Busch wrote:
> On Tue, Sep 17, 2024 at 02:21:04PM +0530, Nilay Shroff wrote:
>> @@ -547,7 +543,11 @@ u16 nvmet_parse_passthru_admin_cmd(struct nvmet_req *req)
>> return NVME_SC_SUCCESS;
>> }
>> return NVME_SC_INVALID_OPCODE | NVME_STATUS_DNR;
>> + case NVME_ID_CNS_CTRL:
>> + fallthrough;
>> case NVME_ID_CNS_NS:
>> + fallthrough;
>> + case NVME_ID_CNS_NS_DESC_LIST:
>
> I'm pretty sure you only need the "fallthrough" statement when you other
> statements inbetween the cases.
>
Alright, I think you prefer combining all three cases together without any
fallthrough in-between them and yes I believe that would also work. I will
send the next patch including yours as well Christoph review comment addressed.
Thank,
--Nilay
prev parent reply other threads:[~2024-09-21 7:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-17 8:51 [PATCH] nvmet-passthru: allow nvme ns-id descriptor list to clear EUID/NGUID/UUID Nilay Shroff
2024-09-18 7:52 ` Nilay Shroff
2024-09-18 12:10 ` Christoph Hellwig
2024-09-20 16:49 ` Keith Busch
2024-09-21 7:05 ` Nilay Shroff [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96531d69-172d-4116-be76-db79085f7fb4@linux.ibm.com \
--to=nilay@linux.ibm.com \
--cc=axboe@fb.com \
--cc=gjoyce@linux.ibm.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox