Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Hannes Reinecke <hare@suse.de>
To: Keith Busch <kbusch@meta.com>,
	hch@lst.de, linux-nvme@lists.infradead.org
Cc: Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH] nvme-multipath: defer partition scanning
Date: Mon, 21 Oct 2024 12:23:29 +0200	[thread overview]
Message-ID: <9761610c-b60e-4e88-a235-6120d80a0b25@suse.de> (raw)
In-Reply-To: <20241015143136.810779-1-kbusch@meta.com>

On 10/15/24 16:31, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
> 
> We need to suppress the partition scan from occuring within the controller's
> scan_work context. If a path error occurs here, the submission will wait until
> a path becomes available or all paths are torn down, but that action also
> occurs within scan_work, so it would deadlock. Defer the partion scan a
> different one that does not block scan_work.
> 
> Reported-by: Hannes Reinecke <hare@suse.de>
> Signed-off-by: Keith Busch <kbusch@kernel.org>
> 
> will be ignored, and an empty message aborts the commit.
> ---
>   drivers/nvme/host/multipath.c | 39 +++++++++++++++++++++++++++++------
>   drivers/nvme/host/nvme.h      |  1 +
>   2 files changed, 34 insertions(+), 6 deletions(-)
> 
Reviewed-by: Hannes Reinecke <hare@suse.de>
Tested-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                  Kernel Storage Architect
hare@suse.de                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich


      parent reply	other threads:[~2024-10-21 10:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-15 14:31 [PATCH] nvme-multipath: defer partition scanning Keith Busch
2024-10-15 15:17 ` Christoph Hellwig
2024-10-20 23:39 ` Sagi Grimberg
2024-10-21 10:23 ` Hannes Reinecke [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9761610c-b60e-4e88-a235-6120d80a0b25@suse.de \
    --to=hare@suse.de \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=kbusch@meta.com \
    --cc=linux-nvme@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox