From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Cc: Christoph Hellwig <hch@lst.de>, Daniel Wagner <wagi@kernel.org>,
Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH blktests 1/2] common/nvme: introduce _have_nvme_cli_with_json_support()
Date: Tue, 20 May 2025 19:18:08 +0000 [thread overview]
Message-ID: <97f436a0-f6aa-4093-85ee-79adef0311c2@nvidia.com> (raw)
In-Reply-To: <20250520061819.1148033-2-shinichiro.kawasaki@wdc.com>
On 5/19/25 23:18, Shin'ichiro Kawasaki wrote:
> To check if the nvme command supports json output format, introduce the
> helper function _have_nvme_cli_with_json_support(), which verifies the
> option "--output-format=" works. While at it, replace the short option
> "-o" in _nvme_connect_subsys() with the long option "--output-format=".
>
> Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
> ---
>
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
next prev parent reply other threads:[~2025-05-20 19:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-20 6:18 [PATCH blktests 0/2] nvme: check that nvme-cli supports json output format Shin'ichiro Kawasaki
2025-05-20 6:18 ` [PATCH blktests 1/2] common/nvme: introduce _have_nvme_cli_with_json_support() Shin'ichiro Kawasaki
2025-05-20 19:18 ` Chaitanya Kulkarni [this message]
2025-05-20 6:18 ` [PATCH blktests 2/2] nvme/rc, md/001: check that nvme-cli supports json output format Shin'ichiro Kawasaki
2025-05-20 19:18 ` Chaitanya Kulkarni
2025-05-20 7:10 ` [PATCH blktests 0/2] nvme: " Daniel Wagner
2025-05-20 13:34 ` Christoph Hellwig
2025-05-28 9:27 ` Shinichiro Kawasaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97f436a0-f6aa-4093-85ee-79adef0311c2@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=linux-nvme@lists.infradead.org \
--cc=shinichiro.kawasaki@wdc.com \
--cc=wagi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox