From: axboe@kernel.dk (Jens Axboe)
Subject: [GIT PULL] nvme updates for Linux 4.15
Date: Fri, 10 Nov 2017 10:38:22 -0700 [thread overview]
Message-ID: <9bcc3b27-0008-b11e-5bbe-4e908326e031@kernel.dk> (raw)
In-Reply-To: <20171110173342.GA15114@infradead.org>
On 11/10/2017 10:33 AM, Christoph Hellwig wrote:
> On Fri, Nov 10, 2017@10:27:24AM -0700, Jens Axboe wrote:
>> That makes for a bit of an awkward merge, why wasn't this fixed up
>> in your tree?
>
> Because you asked me to always base on for-4.15/block last time?
That's not what I meant. It's conflicting because of a patch, that's
fine. But the code in your tree is:
if (a == &dev_attr_uuid.attr) {
if (uuid_is_null(&ids->uuid) ||
!memchr_inv(ids->nguid, 0, sizeof(ids->nguid)))
return 0;
}
and you're saying the right resolution is:
if (a == &dev_attr_uuid.attr) {
if (uuid_is_null(&ids->uuid) ||
!memchr_inv(ids->nguid, 0, sizeof(ids->nguid)))
return 0;
}
My point is that this should have been fixed up in your tree. Yes, it'd
still cause a conflict, that's fine, but at least the merge would not
end up also containing a fix for the above code. That part is not
logical.
--
Jens Axboe
next prev parent reply other threads:[~2017-11-10 17:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-10 14:34 [GIT PULL] nvme updates for Linux 4.15 Christoph Hellwig
2017-11-10 15:18 ` Jens Axboe
2017-11-10 15:22 ` Jens Axboe
2017-11-10 17:22 ` Christoph Hellwig
2017-11-10 17:27 ` Jens Axboe
2017-11-10 17:33 ` Christoph Hellwig
2017-11-10 17:38 ` Jens Axboe [this message]
2017-11-10 17:39 ` Jens Axboe
2017-11-11 8:43 ` Christoph Hellwig
2017-11-11 22:37 ` Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2017-11-03 12:17 Christoph Hellwig
2017-11-03 16:29 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9bcc3b27-0008-b11e-5bbe-4e908326e031@kernel.dk \
--to=axboe@kernel.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox