From: zhangqilong <zhangqilong3@huawei.com>
To: Christoph Hellwig <hch@lst.de>
Cc: "sagi@grimberg.me" <sagi@grimberg.me>,
"hare@suse.de" <hare@suse.de>,
"kbusch@kernel.org" <kbusch@kernel.org>,
"axboe@fb.com" <axboe@fb.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Subject: 答复: [PATCH v2] nvme: fix memleak in nvme_ctrl_dhchap_secret_store()
Date: Wed, 30 Nov 2022 03:49:30 +0000 [thread overview]
Message-ID: <9d0aed3289e04b139cdb9dcd73ce8939@huawei.com> (raw)
In-Reply-To: <20221129134042.GB13668@lst.de>
>
> On Tue, Nov 29, 2022 at 09:47:25AM +0100, Christoph Hellwig wrote:
> > Thanks,
> >
> > applied to nvme-6.1.
>
> And I had to fix it to actually pass all the correct paramters to kmemdup, so it
> looks like this code wasn't even compile test.
>
Oh,
It seems that I forget to do it for V2 version. I am sorry to it, It is so nice that you fix it.
> Btw, how can nvme_ctrl_dhchap_secret_store work without any kind of
> locking?
You means it should need a lock to avoid race condition?
Thanks!
next prev parent reply other threads:[~2022-11-30 3:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-22 4:49 [PATCH v2] nvme: fix memleak in nvme_ctrl_dhchap_secret_store() Zhang Qilong
2022-11-22 9:44 ` Sagi Grimberg
2022-11-29 4:29 ` Chaitanya Kulkarni
2022-11-29 8:47 ` Christoph Hellwig
2022-11-29 13:40 ` Christoph Hellwig
2022-11-30 3:49 ` zhangqilong [this message]
2022-11-30 8:37 ` Sagi Grimberg
2022-11-30 13:37 ` Christoph Hellwig
2022-12-01 1:57 ` 答复: " zhangqilong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d0aed3289e04b139cdb9dcd73ce8939@huawei.com \
--to=zhangqilong3@huawei.com \
--cc=axboe@fb.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox