From: alan.adamson@oracle.com
To: Christoph Hellwig <hch@lst.de>
Cc: linux-nvme@lists.infradead.org, kch@nvidia.com,
kbusch@kernel.org, sagi@grimberg.me
Subject: Re: [PATCH V7 1/1] nvme: allow passthru cmd error logging
Date: Tue, 5 Sep 2023 15:15:24 -0700 [thread overview]
Message-ID: <9d199a50-9f0b-a69d-4061-d443e6286dba@oracle.com> (raw)
In-Reply-To: <20230905065348.GB19754@lst.de>
On 9/4/23 11:53 PM, Christoph Hellwig wrote:
>> if (req->q->queuedata)
>> req->timeout = NVME_IO_TIMEOUT;
>> - else /* no queuedata implies admin queue */
>> + else { /* no queuedata implies admin queue */
>> req->timeout = NVME_ADMIN_TIMEOUT;
>> + if (!nr->ctrl->passthru_err_log_enabled)
>> + req->rq_flags |= RQF_QUIET;
>> + }
>>
>> /* passthru commands should let the driver set the SGL flags */
>> cmd->common.flags &= ~NVME_CMD_SGL_ALL;
>> @@ -687,8 +720,7 @@ void nvme_init_request(struct request *req, struct nvme_command *cmd)
>> if (req->mq_hctx->type == HCTX_TYPE_POLL)
>> req->cmd_flags |= REQ_POLLED;
>> nvme_clear_nvme_request(req);
>> - req->rq_flags |= RQF_QUIET;
> Isn't thisw now dropping the RQF_QUIET flag I/O commands that we
> previously set? While we're at it, why do we only allow passthrough
> error logging for admin commands anyway?
While working through this, we decided that for IO commands (passthrough
or not) error logging would always be enabled. For passthrough admin
commands, error logging could be enabled or disabled.
Alan
next prev parent reply other threads:[~2023-09-05 22:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-31 23:18 [PATCH V7 0/1] nvme: allow passthru cmd error logging Alan Adamson
2023-08-31 23:18 ` [PATCH V7 1/1] " Alan Adamson
2023-09-05 6:53 ` Christoph Hellwig
2023-09-05 22:15 ` alan.adamson [this message]
2023-09-12 11:39 ` Sagi Grimberg
2023-09-19 16:02 ` alan.adamson
2023-12-05 6:06 ` Chaitanya Kulkarni
2023-12-05 10:01 ` Sagi Grimberg
2023-12-07 6:33 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d199a50-9f0b-a69d-4061-d443e6286dba@oracle.com \
--to=alan.adamson@oracle.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).