Re: [PATCH v3 3/4] nvme: Expose the tls_configured sysfs for secure concat connections

Hannes Reinecke
2025-11-14T07:00:37Z

On 11/14/25 05:58, alistair23@gmail.com wrote:
> From: Alistair Francis <alistair.francis@wdc.com>
>
> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> ---
> v3:
> - No change
> v2:
> - New patch
>
> drivers/nvme/host/sysfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/host/sysfs.c b/drivers/nvme/host/sysfs.c
> index 29430949ce2f..6d10e12136d0 100644
> --- a/drivers/nvme/host/sysfs.c
> +++ b/drivers/nvme/host/sysfs.c
> @@ -838,7 +838,7 @@ static umode_t nvme_tls_attrs_are_visible(struct kobject *kobj,
> !ctrl->opts->tls && !ctrl->opts->concat)
> return 0;
> if (a == &dev_attr_tls_configured_key.attr &&
> - (!ctrl->opts->tls_key || ctrl->opts->concat))
> + !ctrl->opts->concat)
> return 0;
> if (a == &dev_attr_tls_keyring.attr &&
> !ctrl->opts->keyring)

Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich