From: Max Gurtovoy <mgurtovoy@nvidia.com>
To: Jens Axboe <axboe@kernel.dk>,
hch@lst.de, sagi@grimberg.me, kbusch@kernel.org,
linux-nvme@lists.infradead.org
Cc: oren@nvidia.com, israelr@nvidia.com
Subject: Re: [PATCH v2 1/1] nvme: move sysfs code to a dedicated sysfs.c file
Date: Mon, 1 May 2023 17:48:04 +0300 [thread overview]
Message-ID: <9e503b24-6345-fabd-be9e-1120226a17cb@nvidia.com> (raw)
In-Reply-To: <0ad22261-6a4e-4f0d-eedf-04dbf2c483a7@kernel.dk>
Hi Christoph,
On 25/04/2023 18:27, Jens Axboe wrote:
> On 4/24/23 3:12?PM, Max Gurtovoy wrote:
>> The core.c file became long and hard to maintain. Create a dedicated
>> file to centralize the sysfs functionality. This is a common practice to
>> separate sysfs/configfs related logic from the main driver logic .c file.
>> For example, in the nvmet module the configfs interface has its own
>> dedicated file.
>>
>> This patch does not include any functional changes.
>
> Reviewed-by: Jens Axboe <axboe@kernel.dk>
>
Is there a chance to merge this for the next round of nvme PR ?
We have pretty good agreement for this patch :)
next prev parent reply other threads:[~2023-05-01 14:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-24 21:12 [PATCH v2 1/1] nvme: move sysfs code to a dedicated sysfs.c file Max Gurtovoy
2023-04-25 15:27 ` Jens Axboe
2023-05-01 14:48 ` Max Gurtovoy [this message]
2023-04-26 11:27 ` Hannes Reinecke
2023-05-12 20:32 ` Christoph Hellwig
2023-05-15 14:57 ` Keith Busch
2023-05-15 17:02 ` Max Gurtovoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e503b24-6345-fabd-be9e-1120226a17cb@nvidia.com \
--to=mgurtovoy@nvidia.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=israelr@nvidia.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=oren@nvidia.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox