From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AE322C4332F for ; Tue, 22 Nov 2022 16:05:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=YMKd/Bs7qgKxK3d2yDLuSvYLpTNEB6rexVneY8E6It8=; b=hLj04HRfESMnjTADJs6t6162EL P6hNXmcR5YN+TNwo0p/+QEbskfC6bE87cHZfCaDUClDFwbzU6NrDU5PeYjrCaQRAYrM0ACnz0qmQa WmiJDJLIxtsqaPXc/AcLxq/lR2Bpt0t181JamIPU2wRTVDvnlJlaYNC/GQ0xIFWJtU0KeN8/eIUwn GU8tlqWhYKUBPhz4qe0bihyyrAI7W3/QgNtYB5DEUqmbzrQeBv6s0Zhg7kxpKD07X/DvUj87boaMJ ZaogQIJdXEgX4HN5MrYzhzp/9Xf8ju95ZzUFVfWO3ZaOHCj/7YBAgbzlxDubqXLUq7m6PG+JIRH4X rl0cm62g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxVmC-00AaBA-Dz; Tue, 22 Nov 2022 16:05:36 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxEro-000ibR-6M for linux-nvme@lists.infradead.org; Mon, 21 Nov 2022 22:02:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669068134; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YMKd/Bs7qgKxK3d2yDLuSvYLpTNEB6rexVneY8E6It8=; b=J9UbiYc/SxnBN1Q4GYUNXqPoHIQoZz3s0CMMTfMeLrQpY46MEy+rvt5XkKYejLJGUQbubI 2/o0ezqglDL8pqHTdaQeIclsMB4sDG2+yOdwknNdkSz62YJ7V52069EInm+mwhICvqtctg AYU2WoT5C99V18BEVJOlGZhogdJIjOQ= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-97-BCJecrIfN9ORT1g62yEryw-1; Mon, 21 Nov 2022 17:02:12 -0500 X-MC-Unique: BCJecrIfN9ORT1g62yEryw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B4575101A5C0; Mon, 21 Nov 2022 22:02:03 +0000 (UTC) Received: from [172.16.176.1] (unknown [10.22.50.7]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1B2304EA47; Mon, 21 Nov 2022 22:01:46 +0000 (UTC) From: Benjamin Coddington To: Shuah Khan Cc: David Howells , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Philipp Reisner , Lars Ellenberg , =?utf-8?q?Christoph_B=C3=B6hmwalder?= , Jens Axboe , Josef Bacik , Keith Busch , Christoph Hellwig , Sagi Grimberg , Lee Duncan , Chris Leech , Mike Christie , "James E.J. Bottomley" , "Martin K. Petersen" , Valentina Manea , Shuah Khan , Greg Kroah-Hartman , Marc Dionne , Steve French , Christine Caulfield , David Teigland , Mark Fasheh , Joel Becker , Joseph Qi , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Ilya Dryomov , Xiubo Li , Trond Myklebust , Anna Schumaker , Chuck Lever , Jeff Layton , drbd-dev@lists.linbit.com, linux-block@vger.kernel.org, nbd@other.debian.org, linux-nvme@lists.infradead.org, open-iscsi@googlegroups.com, linux-scsi@vger.kernel.org, linux-usb@vger.kernel.org, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com, v9fs-developer@lists.sourceforge.net, ceph-devel@vger.kernel.org, linux-nfs@vger.kernel.org Subject: Re: [PATCH v1 2/3] Treewide: Stop corrupting socket's task_frag Date: Mon, 21 Nov 2022 17:01:42 -0500 Message-ID: In-Reply-To: <26d98c8f-372b-b9c8-c29f-096cddaff149@linuxfoundation.org> References: <382872.1669039019@warthog.procyon.org.uk> <51B5418D-34FB-4E87-B87A-6C3FCDF8B21C@redhat.com> <4585e331-03ad-959f-e715-29af15f63712@linuxfoundation.org> <26d98c8f-372b-b9c8-c29f-096cddaff149@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221121_140216_384191_8DDBF0AB X-CRM114-Status: GOOD ( 13.92 ) X-Mailman-Approved-At: Tue, 22 Nov 2022 08:05:24 -0800 X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On 21 Nov 2022, at 16:43, Shuah Khan wrote: > On 11/21/22 14:40, Shuah Khan wrote: >> On 11/21/22 07:34, Benjamin Coddington wrote: >>> On 21 Nov 2022, at 8:56, David Howells wrote: >>> >>>> Benjamin Coddington wrote: >>>> >>>>> Since moving to memalloc_nofs_save/restore, SUNRPC has stopped sett= ing the >>>>> GFP_NOIO flag on sk_allocation which the networking system uses to = decide >>>>> when it is safe to use current->task_frag. >>>> >>>> Um, what's task_frag? >>> >>> Its a per-task page_frag used to coalesce small writes for networking= -- see: >>> >>> 5640f7685831 net: use a per task frag allocator >>> >>> Ben >>> >>> >> >> I am not seeing this in the mainline. Where can find this commit? >> > > Okay. I see this commit in the mainline. However, I don't see the > sk_use_task_frag in mainline. sk_use_task_frag is in patch 1/3 in this posting. https://lore.kernel.org/netdev/26d98c8f-372b-b9c8-c29f-096cddaff149@linux= foundation.org/T/#m3271959c4cf8dcff1c0c6ba023b2b3821d9e7e99 Ben