From: "Maurizio Lombardi" <mlombard@bsdbackstore.eu>
To: "Hannes Reinecke" <hare@suse.de>,
"Maurizio Lombardi" <mlombard@redhat.com>, <kbusch@kernel.org>
Cc: <axboe@kernel.dk>, <hch@lst.de>, <sagi@grimberg.me>,
<linux-nvme@lists.infradead.org>, <hare@kernel.org>
Subject: Re: [PATCH] nvme-tcp: add basic support for the C2HTermReq PDU
Date: Mon, 24 Feb 2025 17:48:38 +0100 [thread overview]
Message-ID: <D80TVRHC1LFG.RHYVKMPXX3DF@bsdbackstore.eu> (raw)
In-Reply-To: <0e3af565-f8e6-4647-89c3-6757f6bae3a6@suse.de>
On Mon Feb 24, 2025 at 5:04 PM CET, Hannes Reinecke wrote:
> I really wouldn't be doing that, as we need to terminate the queue upon
> fatal error and don't really want to delay that (eg by waiting for the
> transfer to finish) and
I did some tests and it seems to work with MSG_DONTWAIT as well.
I am just wondering if calling kernel_sock_shutdown() could
in some cases race with MSG_DONTWAIT, preventing the packet from
being effectively sent.
Not a big problem anyway because, as you said, it's a kind
of best-effort thing.
Maurizio
next prev parent reply other threads:[~2025-02-24 16:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-14 19:00 [PATCH] nvme-tcp: add basic support for the C2HTermReq PDU Maurizio Lombardi
2025-02-17 8:14 ` Sagi Grimberg
2025-02-17 13:26 ` Maurizio Lombardi
2025-02-17 10:56 ` Hannes Reinecke
2025-02-17 13:29 ` Maurizio Lombardi
2025-02-24 14:38 ` Maurizio Lombardi
2025-02-24 16:04 ` Hannes Reinecke
2025-02-24 16:48 ` Maurizio Lombardi [this message]
2025-02-24 17:03 ` Hannes Reinecke
2025-02-25 7:41 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D80TVRHC1LFG.RHYVKMPXX3DF@bsdbackstore.eu \
--to=mlombard@bsdbackstore.eu \
--cc=axboe@kernel.dk \
--cc=hare@kernel.org \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mlombard@redhat.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox